[#12679] - [Smart Search] Add peak memory usage to CLI indexer
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 12679
- Diff
- chrisdavenport:ss-cli-memory-usage
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Merely adds the peak memory usage to the output of the Smart Search CLI indexer.
Testing Instructions
Run the CLI indexer and look for the new line in the output. Here's an example:
Starting Indexer
Setting up Smart Search plugins
Setup 8 items in 0.154 seconds.
* Processed batch 1 in 0.052 seconds.
Total Processing Time: 0.207 seconds.
Peak memory usage: 6,291,456 bytes
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | CLI Language & Strings |
CLI is doing it all in one process. Web is doing it in batches so the memory use is per batch (per process since it's multiple AJAX requests).
if i'm not wrong i think the CLI do it in quite the same way as the WEB https://github.com/chrisdavenport/joomla-cms/blob/2a7af71dfc53a5986de128b34bf6711fd8c53feb/cli/finder_indexer.php#L202
Right, CLI does run in batches, but it's all in the context of one long running process versus the web doing it in several processes. So unless Chris changes it to track the memory use per batch, just from reading the discussions here I think he's tracking the memory use for the entire process in each context (so one of the AJAX requests for the web and the full CLI run).
tracking the memory use for the entire process
yes i think this too
i was trying to compare both way results to calculate the "gain", maybe i have wanted to compare apples with pears ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12679.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12679.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12679.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 21:55:52 |
| Closed_By | ⇒ | rdeutz |
i've noticed some differences on how behave the display of the "Peak memory usage" from CLI to WEB
from the CLI we have only one display at end of the index process
from the WEB we have one display for each batch process
