? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Nov 2016

Pull Request for Issue #12659.

Summary of Changes

Removes the modal files as they are not needed anymore because the content plugin support was removed. More information can be found here joomla-projects/custom-fields#12 and here joomla-projects/custom-fields#135.

If content support will be added then we need to add them as well as we can then implement an editor button to select fields in a description of an article.

Testing Instructions

All should work as before.

Documentation Changes Required

avatar laoneo laoneo - open - 1 Nov 2016
avatar laoneo laoneo - change - 1 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2016
Category Administration Components
avatar laoneo laoneo - change - 1 Nov 2016
Title
Remove obsolete modals
[com_fields] Remove obsolete modals
avatar laoneo laoneo - edited - 1 Nov 2016
avatar laoneo laoneo - change - 1 Nov 2016
Title
Remove obsolete modals
[com_fields] Remove obsolete modals
avatar infograf768
infograf768 - comment - 1 Nov 2016

Tested OK. Missing commit SHA to use tests succesful


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12672.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Nov 2016

ok on code review

avatar mbabker
mbabker - comment - 1 Nov 2016

Missing commit SHA to use tests succesful

Refresh your browser cache. Though that shouldn't be happening anymore at all; that was fixed two weeks ago and the cache directives for the tracker only cache CSS and JavaScript for one week.

avatar alikon alikon - test_item - 1 Nov 2016 - Tested successfully
avatar alikon
alikon - comment - 1 Nov 2016

I have tested this item successfully on ab370ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12672.

avatar laoneo
laoneo - comment - 1 Nov 2016

So is this RTC ?

avatar infograf768 infograf768 - change - 2 Nov 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 2 Nov 2016

rtc anyway


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12672.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Labels Added: ?
avatar infograf768 infograf768 - test_item - 2 Nov 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 2 Nov 2016

I have tested this item successfully on ab370ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12672.

avatar zero-24 zero-24 - close - 2 Nov 2016
avatar wilsonge wilsonge - change - 2 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-02 15:01:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Nov 2016
avatar wilsonge wilsonge - merge - 2 Nov 2016
avatar zero-24 zero-24 - change - 2 Nov 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment