?
avatar MartijnMaandag
MartijnMaandag
31 Oct 2016

JGLOBAL_FIELD_SHOW_BASE_DESCRIPTION_LABEL and JGLOBAL_FIELD_CATEGORIES_DESC_LABEL do have the same text: "Top Level Category Description"

Steps to reproduce the issue

Go to New Menu - Menu Item Type = List All News Feed Categories
Go to tab "Categories" and you will find two fields with the name Top Level Category Description.
I think it is better to rename the second one into "Description Override"
So
JGLOBAL_FIELD_CATEGORIES_DESC_LABEL must be something like "Description Override"

Expected result

Actual result

System information (as much as possible)

Additional comments

avatar MartijnMaandag MartijnMaandag - open - 31 Oct 2016
avatar brianteeman
brianteeman - comment - 31 Oct 2016

How about "Alternative Description"

On 31 October 2016 at 16:18, Martijn Maandag notifications@github.com
wrote:

JGLOBAL_FIELD_SHOW_BASE_DESCRIPTION_LABEL and
JGLOBAL_FIELD_CATEGORIES_DESC_LABEL do have the same text: "Top Level
Category Description"
Steps to reproduce the issue

Go to New Menu - Menu Item Type = List All News Feed Categories
Go to tab "Categories" and you will find two fields with the name Top
Level Category Description.
I think it is better to rename the second one into "Description Override"
So
JGLOBAL_FIELD_CATEGORIES_DESC_LABEL must be something like "Description
Override"
Expected result Actual result System information (as much as possible) Additional
comments

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12665, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8QK5m1QvdUuzCSSqIxYUb3oUi-tUks5q5hTbgaJpZM4KlM7n
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 31 Oct 2016

and then the tooltips would be changed to
JGLOBAL_FIELD_SHOW_BASE_DESCRIPTION_DESC="Show description of the top level category or alternatively replace with the text from the description field found in the menu item. If using Root as a top level category, the description field has to be filled."

JGLOBAL_FIELD_CATEGORIES_DESC_DESC="If you enter some text in this field, it will replace the Top Level Category Description, if it has one."

avatar MartijnMaandag
MartijnMaandag - comment - 1 Nov 2016

Yes this is better, "Override" is very technical.

avatar brianteeman
brianteeman - comment - 1 Nov 2016

Ok Martijn - thanks for confirming that - I will prepare a pull request
when i finish replying to all the facebook greetings ;)

On 1 November 2016 at 08:04, Martijn Maandag notifications@github.com
wrote:

Yes this is better, "Override" is very technical.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12665 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8du01wTsgrZfqKBRZFuHbetHDndpks5q5vJ7gaJpZM4KlM7n
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 1 Nov 2016

Closed as we have a PR for testing #12677

avatar brianteeman brianteeman - change - 1 Nov 2016
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-01 09:09:06
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - close - 1 Nov 2016

Add a Comment

Login with GitHub to post a comment