Labels |
Added:
?
|
I can see it being an issue with other languages that make it difficult to play Scrabble (*cough*
German *cough*
), but I don't think that's a good default behavior because as seen here it's now causing undesired breaks in other ways.
Agreed. It wasn't introduced by a native English speaker
The break-word class has been applied to pretty much everywhere that we display a title. If its going to be "reverted" here then it needs to be reviewed in all the other uses
Category | ⇒ | Templates (admin) |
Status | New | ⇒ | Confirmed |
Setting to needs review. can someone make a decision if we should revert the addition of adding the break-word class
Status | Confirmed | ⇒ | Needs Review |
We do do hyphens as another option, checkout:
https://css-tricks.com/snippets/css/prevent-long-urls-from-breaking-out-of-container/
Which language have very long words and who decide that?
And which language take affect? Conten language the admin language the user language the language of the content item th default language? How we handle "all" language?
It can't be language specific. As displayed, that's a default single language English Joomla install.
But in which scenario would you have an english word that long? by default it shouldn't break english words and should return the word down a line surely? my suggest was just if it was effecting certain languages we could allow a word around by adding a break class for that language.
It's not affecting certain languages though, as displayed by the screenshot. The CSS declaration is too "eager" and it's causing inappropriate breaks in the middle of words. I get the intent of the PR adding it, but it has introduced unwanted side effects.
I don't think locale specific CSS is the appropriate fix.
No what I am saying is we revert the change so it doesn't force a line break. But we could add a language class based on the used language code to the titles so for the user who implemented the break-word css we could still apply it for any specific language where it might apply that the word it too long.
But in any case, the main thing is to revert the break word css.
It's still making an arbitrary decision based on a language code, that seems like a bad idea to me.
As for adding the language code as a class to the title, that is unneeded. We already have a language tag in the header and CSS is able to act on that using :lang()
Why not just keep it on one line and truncate with ellipsis?
https://css-tricks.com/snippets/css/truncate-string-with-ellipsis/
Then add the full value to the title attribute so it can be seen on hover.
Closed
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 20:03:56 |
Closed_By | ⇒ | brianteeman |
Iirc break word was introduced to resolve the non existent issue of having
long titles with no spaces in them