?
avatar mbabker
mbabker
30 Oct 2016

Steps to reproduce the issue

Set some longer article titles, add the popular articles module to the admin control panel with a span6 width

Expected result

Words break correctly

Actual result

Words break in the middle

screen shot 2016-10-30 at 3 21 50 pm

System information (as much as possible)

Joomla! 3.6.4

avatar mbabker mbabker - open - 30 Oct 2016
avatar brianteeman
brianteeman - comment - 30 Oct 2016

Iirc break word was introduced to resolve the non existent issue of having
long titles with no spaces in them

avatar zero-24 zero-24 - change - 30 Oct 2016
Labels Added: ?
avatar mbabker
mbabker - comment - 30 Oct 2016

I can see it being an issue with other languages that make it difficult to play Scrabble (*cough* German *cough*), but I don't think that's a good default behavior because as seen here it's now causing undesired breaks in other ways.

avatar brianteeman
brianteeman - comment - 30 Oct 2016

Agreed. It wasn't introduced by a native English speaker

avatar zero-24
zero-24 - comment - 30 Oct 2016

(cough German cough)

I don't have this issue on my german site. ;)

Agreed. It wasn't introduced by a native English speaker

I'm not sure it was declared as quick fix #5525 ;)

avatar brianteeman
brianteeman - comment - 30 Oct 2016

The break-word class has been applied to pretty much everywhere that we display a title. If its going to be "reverted" here then it needs to be reviewed in all the other uses


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12648.

avatar brianteeman brianteeman - edited - 2 Nov 2016
avatar brianteeman brianteeman - change - 2 Nov 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 2 Nov 2016
Status New Confirmed
avatar brianteeman
brianteeman - comment - 2 Nov 2016

Setting to needs review. can someone make a decision if we should revert the addition of adding the break-word class


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12648.

avatar brianteeman brianteeman - change - 2 Nov 2016
Status Confirmed Needs Review
avatar tonypartridge
tonypartridge - comment - 2 Dec 2016

What about... wait for it.. we add the language code to the title class? Then the languages with super long words can have CSS applied to break on that scenario. As I agree with @mbabker with English being default it looks a bit of a mess.

avatar tonypartridge
tonypartridge - comment - 2 Dec 2016
avatar zero-24
zero-24 - comment - 2 Dec 2016

Which language have very long words and who decide that?

avatar zero-24
zero-24 - comment - 2 Dec 2016

And which language take affect? Conten language the admin language the user language the language of the content item th default language? How we handle "all" language?

avatar mbabker
mbabker - comment - 2 Dec 2016

It can't be language specific. As displayed, that's a default single language English Joomla install.

avatar tonypartridge
tonypartridge - comment - 2 Dec 2016

But in which scenario would you have an english word that long? by default it shouldn't break english words and should return the word down a line surely? my suggest was just if it was effecting certain languages we could allow a word around by adding a break class for that language.

avatar mbabker
mbabker - comment - 2 Dec 2016

It's not affecting certain languages though, as displayed by the screenshot. The CSS declaration is too "eager" and it's causing inappropriate breaks in the middle of words. I get the intent of the PR adding it, but it has introduced unwanted side effects.

I don't think locale specific CSS is the appropriate fix.

avatar tonypartridge
tonypartridge - comment - 2 Dec 2016

No what I am saying is we revert the change so it doesn't force a line break. But we could add a language class based on the used language code to the titles so for the user who implemented the break-word css we could still apply it for any specific language where it might apply that the word it too long.

But in any case, the main thing is to revert the break word css.

avatar mbabker
mbabker - comment - 2 Dec 2016

It's still making an arbitrary decision based on a language code, that seems like a bad idea to me.

avatar Bakual
Bakual - comment - 2 Dec 2016

Imho, that PR should be reverted. As of today, users can add a user.css to add such CSS rules if they need it. Having it by default makes things worse for more users than it helps for the few cases.

@mbabker What's wrong with "Binnenseedampfschiffahrtsgesellschaft"? ?

avatar Bakual
Bakual - comment - 2 Dec 2016

As for adding the language code as a class to the title, that is unneeded. We already have a language tag in the header and CSS is able to act on that using :lang()

avatar mbabker
mbabker - comment - 2 Dec 2016

@mbabker What's wrong with "Binnenseedampfschiffahrtsgesellschaft"? ?

Well, according to Google Translate it's missing a space character. And if that's correct, I see no issues with a "Inland waterways steamship company" other than their title is too damn long.

avatar severdia
severdia - comment - 8 Feb 2017

Why not just keep it on one line and truncate with ellipsis?

https://css-tricks.com/snippets/css/truncate-string-with-ellipsis/

Then add the full value to the title attribute so it can be seen on hover.

avatar Quy
Quy - comment - 29 May 2017

@mbabker Close per #16257

avatar brianteeman
brianteeman - comment - 29 May 2017

Closed

avatar brianteeman brianteeman - change - 29 May 2017
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2017-05-29 20:03:56
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 May 2017

Add a Comment

Login with GitHub to post a comment