? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Oct 2016

Pull Request for Issue #12645
and for issue #12633

Summary of Changes

Prevents fields menu and sidebar from displaying when com_fields is not enabled.
Displays a Warning if the fields system plugin is disabled.
Corrected 2 fatal errors JFolder and JFile not found when saving a custom field.
Alpha ordered and modified the xml_description language string for the system plugin as the custom fields will NOT display if disabled.

Testing Instructions

Patch
Disable the component com_fields in Extensions Manager=>Manage
result: menus and sidebar do not show (Users, contacts, content)

Then enable it again and disable the fields system plugin. Display the fields manager
Result : a Warning is displayed in the manager
screen shot 2016-10-31 at 08 03 22

Create a new custom field and save. Before patch fatal error, after, it saves fine

TODO: change the fields manager and fields group manager title to fit the component concerned

avatar infograf768 infograf768 - open - 30 Oct 2016
avatar infograf768 infograf768 - change - 30 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2016
Category Administration Components Modules Libraries
avatar infograf768 infograf768 - change - 31 Oct 2016
The description was changed
avatar infograf768 infograf768 - change - 31 Oct 2016
The description was changed
avatar infograf768
infograf768 - comment - 31 Oct 2016

Modified test instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12646.

avatar infograf768 infograf768 - edited - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Category Administration Components Modules Libraries Administration Components Language & Strings Modules Libraries
avatar infograf768
infograf768 - comment - 31 Oct 2016

@laoneo
@brianteeman
@andrepereiradasilva
@coolcat-creations
@rdeutz

Please test. That is one of the multiple PRs to correct com_fields.

avatar infograf768 infograf768 - change - 31 Oct 2016
The description was changed
avatar infograf768 infograf768 - edited - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 31 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Oct 2016

I have tested this item successfully on c05c148

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12646.

avatar wilsonge wilsonge - alter_testresult - 31 Oct 2016 - stevejburge: Tested successfully
avatar wilsonge
wilsonge - comment - 31 Oct 2016

As @stevejburge tested this successfully (mentioned in #11833) merging this with two good tests

avatar wilsonge wilsonge - reference | 490674a - 31 Oct 16
avatar wilsonge wilsonge - merge - 31 Oct 2016
avatar wilsonge wilsonge - close - 31 Oct 2016
avatar wilsonge wilsonge - change - 31 Oct 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-31 15:55:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Oct 2016
avatar wilsonge wilsonge - merge - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Milestone Added:

Add a Comment

Login with GitHub to post a comment