? ? Success

User tests: Successful: Unsuccessful:

avatar tstahl-git
tstahl-git
28 Oct 2016

Summary of Changes

Get JRule data rather than JRule object

Testing Instructions

Apple patch and check result

avatar tstahl-git tstahl-git - open - 28 Oct 2016
avatar tstahl-git tstahl-git - change - 28 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2016
Category Front End Plugins
avatar zero-24
zero-24 - comment - 29 Oct 2016

@tstahl-git it looks like this PR is broken and include some invalid commits how can we reproduce the error / problem as my sites send the messages out since the plugin was added.?

avatar tstahl-git
tstahl-git - comment - 30 Oct 2016

@zero-24 yes, something went wrong. The only file to patch should be updatenotification.php.
I have 2 server installations where notification won't work.
I made a fresh installation from the staging branch with the same result.
With the proposed patch for updatenotification.php the notification works for me.
The origin line "298 $rawGroups = $rules['core.admin'];" returns a JRule object and not an array.
Please investigate.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12614.

avatar zero-24
zero-24 - comment - 5 Nov 2016

Ok i can confirm the problem and i have created a new PR that is cleaned up at #12763

avatar zero-24 zero-24 - change - 5 Nov 2016
The description was changed
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-05 08:43:53
Closed_By zero-24
avatar zero-24 zero-24 - close - 5 Nov 2016
avatar zero-24 zero-24 - close - 5 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2016
Category Front End Plugins Administration Components Templates (admin) Front End SQL Installation Postgresql MS SQL Libraries Plugins Templates (site) Unit Tests
avatar zero-24
zero-24 - comment - 5 Nov 2016

Thanks for reporting!

Add a Comment

Login with GitHub to post a comment