[#12608] - Implement a check / notification for an invalid or missing access file
- Fixed in Code Base
- 28 Oct 2016
- Medium
- Build: staging
- # 12608
- Diff
- matrikular:patch-14
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR implements a check and notification for an invalid or missing access file that is accessed in both core and 3rd party extensions via the JHelperContent::getActions method.
In the current implementation, depending on the error reporting level, an invalid argument warning would be either shown to the user or written to the php error log file.
Testing Instructions
- Set the error reporting level of your (test) installation to maximum (Global Configuration - Server Settings - Error Reporting)
- Head over to the file system and rename an access.xml for e.g. administrator/components/com_banners to access.xml_
- Open the banners component in the backend. You should see something similar to this:
In a normal running website, the error reporting level would be set to "System Default" (reporting). The only indication for an invalid or missing access file, is just a few missing toolbar buttons.
- Apply the patch. You should see an error message like the one in the screenshot below.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Removed:
?
|
||
ignore that comment. I see now that was to fix an error in the PR and you are not removing a string
I have tested this item
Works like described, thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12608.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12608.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12608.
I have also tested this item successfully!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12608.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12608.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-28 18:28:39 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I wouldn't put the entire file path in the message. Try this: "The %s component's ACL configuration file is either missing or improperly structured.", merge in the component's name. If this message ever displays on the frontend as is that would be a full path disclosure.