?
avatar SharkyKZ
SharkyKZ
27 Oct 2016

Steps to reproduce the issue

Upload a Joomla! package in com_joomlaupdate. When it asks for credential, enter correct credentials but use different case for username (e.g. if your username is admin, enter Admin)

Expected result

Confirmation successful, installation proceeds.

Actual result

403 Access Forbidden error.

System information (as much as possible)

Joomla! 3.6.4, PHP 7.0.9.

Additional comments

I'm not sure if this is intentional or not but it is inconsistent with other login forms. If this is intentional, case-sensitive requirement should at least be indicated in the form.

avatar SharkyKZ SharkyKZ - open - 27 Oct 2016
avatar zero-24
zero-24 - comment - 27 Oct 2016

I'm not 100% sure but please try this: staging...zero-24:username_login I can make a PR if that works. Thanks!

avatar zero-24 zero-24 - change - 27 Oct 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 27 Oct 2016

I rather think we should solve the issue for the other login forms, i.e. never accept differences in lower-upper case as this would be contradictory to our Configuration:

screen shot 2016-10-27 at 17 47 16

Why would we impose a minimum number of UpperCase if this is not implemented?

avatar infograf768
infograf768 - comment - 27 Oct 2016

EDIT:
Sorry, this concerns passwords, not User name

avatar brianteeman
brianteeman - comment - 27 Oct 2016

lol - you had me confused there

avatar infograf768
infograf768 - comment - 27 Oct 2016

I am still extremely confused: why do we accept lower and upper entries for the username in the other login forms (just tested and indeed, one can login).
This looks wrong to me.

avatar brianteeman
brianteeman - comment - 27 Oct 2016

fairly common for usernames not to be case sensitive.

avatar yvesh
yvesh - comment - 27 Oct 2016

But SharkyKz is right on the updater (captive login) we are case sensitive for usernames on the login not.

avatar infograf768
infograf768 - comment - 27 Oct 2016

@yvesh
Indeed joomlaupdate does not behave the same as other login forms but I wonder if it should not be safer to enforce a case-sensitive user name elsewhere instead of modifying the one in joomlaupdate.

avatar yvesh
yvesh - comment - 27 Oct 2016

@infograf768 yep that's true. But in the first case the behavior should be equal on all areas.

@zero-24 Any reason you don't use strcasecmp ?? :-)

avatar zero-24
zero-24 - comment - 27 Oct 2016

@yvesh no i just want to be sure the issue comes from that part of the code ;)

avatar infograf768
infograf768 - comment - 27 Oct 2016

Folks, I just tested a new install and I confirm that sql does NOT accept case-insensitive Username.
Why would Joomla accept?

avatar brianteeman
brianteeman - comment - 27 Oct 2016

Not just Joomla - any system that uses an email address as the username for example will be case insensitive

avatar SharkyKZ
SharkyKZ - comment - 27 Oct 2016

@zero-24 your solution works.

avatar brianteeman brianteeman - change - 28 Oct 2016
Category com_joomlaupdate
avatar brianteeman brianteeman - change - 28 Oct 2016
Status New Confirmed
avatar tonypartridge
tonypartridge - comment - 4 Dec 2016

I'm with Brian it is extremely common from a user perspective to allow upper and lower case in username which can be used for login. Many times the user may start with a capital for example if writing on an iPhone and so on. It's accepted because users can be stupid (I know way too much after seeing this first hand after laughing a website for a client recently and they didn't even read the bright login they click to continue before logging in).

I would use @zero-24 solution too.

avatar Bakual
Bakual - comment - 4 Dec 2016

It's accepted because users can be stupid

The reason is more that the username isn't considered a secret element. It's also not saved encrypted in the database and sometimes even is shown on the page. Thus case sensitivity isn't of concern.
Only the password is considered a secret and thus it has to match exactly.

avatar mbabker
mbabker - comment - 4 Dec 2016

Either way it's a major inconsistency. This is the only part of the system that seems to have a case sensitive requirement so should be adjusted (it looks like Tobias' patch would do the trick).

avatar brianteeman
brianteeman - comment - 21 May 2017

@zero-24 can you please make a Pr based on staging...zero-24:username_login so that we can close this and move on

avatar zero-24 zero-24 - change - 21 May 2017
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2017-05-21 14:09:02
Closed_By zero-24
avatar zero-24 zero-24 - close - 21 May 2017
avatar zero-24
zero-24 - comment - 21 May 2017

Done. looks like i have forgotten this over the time. Thanks for the reminder.

avatar zero-24
zero-24 - comment - 21 May 2017

PR is #16167

Add a Comment

Login with GitHub to post a comment