[#12585] - Remove hardcoded published column from JTableNested
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: staging
- # 12585
- Diff
- phproberto:nested-published
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
1. Issue description
Joomla allows flexible columns for columns like published, checked_out, etc. You just have to define in your table a property like:
/**
* Array with alias for "special" columns such as ordering, hits etc etc
*
* @var array
*/
protected $_columnAlias = array(
'published' => 'state'
);And Joomla will be able to publish & unpublish items using the state column. That works perfectly for tables that extend JTable but does not for tables that extend JTableNested.
2. Summary of Changes
This replaces the hardcoded published column with $this->getColumnAlias('published') which defaults to published if alias is not defined. So it should be 100% compatible.
3. Testing Instructions.
- Apply the patch.
- Go to
Content>Categoriesand try to publish & unpublish some categories. - Ensure that no errors are shown.
- Ensure that unpublishing a category with children also unpublishes child categories.
- Ensure that publishing a category with children also publishes child categories.
4. Documentation Changes Required
This is an improvement to make tables more flexible and has no implications on documentation.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
@RonakParmar i have just added your test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
@zero-24 Thanks for assist. :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
@ronakparmar clear your browser cache to solve the test result issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
@brianteeman Thank you for the help, I have checked in another browser and worked fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
@mbabker can you take a look into the issue tracker problem?
The only "problem" is we have lengthy caching of media on the tracker so when asset changes are pushed it requires a cache refresh.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks Roberto
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 09:37:22 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this PR successfully but not able to submit my test result. I am getting "Missing commit SHA." error while submitting test result, please see the attached screen-dump.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12585.