Nope - its not done
all the code does is check that - customurl is not just "not empty".

It still does not
check if the customurl is valid and not just "not empty".

yes but define "valid" ?

The validation should be done at the time of saving a custom url to the db - not at the time of using it.

No idea how to define valid BUT its still a todo

if (filter_var(trim($params->get('customurl', ''), FILTER_VALIDATE_URL) === true)

@PhilETaylor this should do exactly that

If you enter an invalid url then its still fine, it fails gracefully.

thats an invalid url but I read the todo as suggesting it should be testing for a genuine url and not something like joornla.org

@brianteeman this one maybe?

try
{
simplexml_load_string(file_get_contents($url))
}
catch
//error
}

Data should be validated before it gets to the database, not just on retrieving it from the database. This file is the wrong place for basic validation checks period.

thats why its a todo ;)

On 26 October 2016 at 23:42, Phil Taylor notifications@github.com wrote:

Data should be validated before it gets to the database, not on retrieving
it from the database. This file is the wrong place for basic validation
checks period.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12582 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YeuCqKk0_1TdjzclrjK5swPTYILks5q39dtgaJpZM4Khvg-
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

how does that stop me using http://update.joornla.org/

On 26 October 2016 at 23:41, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman this one maybe?

try{simplexml_load_string(file_get_contents($url))}catch//error}

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12582 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8a3L23Ha2pHoFOHu3E3w_F39S4Gfks5q39cmgaJpZM4Khvg-
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/