[#12571] - Remove unneeded registry creation
- Fixed in Code Base
- 19 Dec 2016
- Medium
- Build: staging
- # 12571
- Diff
- Bakual:RemoveUnneededRegistryCreation
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for similar Issue #12557.
Summary of Changes
Referenced PR changes one instance where we tried to create a Registry object from a Registry object.
After scanning the PR which introduced that bug I found several more instances of the same error. This is corrected in this PR.
Testing Instructions
I did this PR based on code review and debugging (looking at the values of he params during runtime).
To test you can do the same review/debugging: If the params property is already a Registry object it will fail to create one and it doesn't make sense to create one for obvious reasons.
To test in real you need to set some parameters at item level and check that the item params take precedence over menu/component params if needed.
- Contact Item in category, featured and single contact view
- Newsfeed Item in category and single newsfeed view
- In the search view for the traditional search (com_search) you need to check the behavior of the page title parameter in the menu item. If none is specified it should fall back to the default language string, if one is specified it has to take the specified one.
- Last change is in the template override feature, but I'm not 100% sure how to test it. Adding
?template=beez3to the URL brings you to the code I changed, however I'm not sure which params are used there since no template style is specified. I guess it will just use default values but not sure.
The code itself is a no brainer since a few lines above the params are already converted to Registry, so this can be reviewed easily.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components Libraries |
| Labels |
Added:
?
Removed: ? |
||
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
| Category | Front End Components Libraries | ⇒ | Front End com_contact com_newsfeeds Components |
Rebased
A bit hard to set up a test environment. Can you tell us how we can reproduce the issue.
I don't remember if there was an issue in those cases.
It's just that $item->params is already a Registry object and doesn't need to be created again with new Registry($item->params). Trying to do that actually results in an error and the merging doesn't work correctly. The merge will end up with a Registry object within a Registry object instead of merging it.
Easy to see when you debug it, but I haven't looked where exactly those come from and how the issue could be made viewable.
Should be fine now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12571.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12571.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12571.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-19 14:49:47 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
Branch has a conflict, can you please fix it that I can test.