?
avatar joeforjoomla
joeforjoomla
25 Oct 2016

Steps to reproduce the issue

Use a default class btn-default for configuration buttons not working anymore

Expected result

Normal buttons layout red/green

Actual result

Broken buttons layout, all btn-default

System information (as much as possible)

This is caused by changes to the following styles in the Isis template, now missing:

.btn-danger:hover,
.btn-danger:focus,
.btn-danger:active,
.btn-danger.active,
.btn-danger.disabled,
.btn-danger[disabled] {
color: #fff;
background-color: #942a25;
*background-color: #802420;
}

and

.btn-success:hover,
.btn-success:focus,
.btn-success:active,
.btn-success.active,
.btn-success.disabled,
.btn-success[disabled] {
color: #fff;
background-color: #378137;
*background-color: #2f6f2f;
}

In Joomla 3.7 they turned to the following, missing additional pseudo classes and breaking the cascade overrides in some cases:

.btn-danger:hover,
.btn-danger:focus {
background-color: #802420;
color: #fff;
text-decoration: none;
}

.btn-success:hover,
.btn-success:focus {
background-color: #2f6f2f;
color: #fff;
text-decoration: none;
}

Additional comments

Revert back to the full pseudo classes selectors.

buttons_broken

avatar joeforjoomla joeforjoomla - open - 25 Oct 2016
avatar brianteeman brianteeman - change - 25 Oct 2016
Labels Added: ?
avatar ciar4n
ciar4n - comment - 26 Oct 2016

Could you detail how to replicate these buttons? The issue isn't present with any of the standard Joomla field types.

avatar joeforjoomla
joeforjoomla - comment - 26 Oct 2016

It happens with some extension depending on the CSS overrides. When buttons have the class 'btn-default' they lose the color, because of the changes reported above.

avatar ciar4n
ciar4n - comment - 26 Oct 2016

Could you give an example of such an extension?

avatar joeforjoomla
joeforjoomla - comment - 26 Oct 2016

I found happening for all extensions adding using javascript the following 'btn-default' class to the buttons:

$('input[type=radio]~label').addClass('radio btn btn-default');

avatar ciar4n
ciar4n - comment - 26 Oct 2016

The standard way for creating such buttons is with the following xml...

<field name="myradiovalue" type="radio" default="0" label="Select an option" description="" class="btn-group">
  <option value="0">1</option>
  <option value="1">2</option>
</field>

If you have an extension that uses an alternative method, I would need access to test it or at least a detailed description on how to replicate the buttons.

avatar C-Lodder
C-Lodder - comment - 26 Oct 2016

btn-default is not used in Bootstrap 2. It's used in Bootstrap 3 and above.

To create a button group in Joomla, you should use the method provided in the comment above. If your extension doesn't do that, then they need to fix their extension.

Perhaps the extension you're using is importing Bootstrap 3 for some odd reason, but without knowing which extension it is, it's hard to tell.

avatar brianteeman
brianteeman - comment - 26 Oct 2016

I found happening for all extensions adding using javascript the following 'btn-default' class to the buttons:

Please as we provide an example

avatar brianteeman
brianteeman - comment - 26 Oct 2016

Dam autocorrect.

Please provide a sample extension

avatar brianteeman brianteeman - change - 26 Oct 2016
Category Templates (admin)
avatar mbabker
mbabker - comment - 26 Oct 2016

3.6 does not have style rules for a btn-default class (though it is used in a handful of elements, I presume for forward compatibility with Bootstrap 3). The highlighted CSS changes are unrelated to this class. Presumably if anything the btn class definitions have changed, though 100% intended with the re-skinning of the template included in 3.7.

Without providing a sample extension or at a minimum a form definition (and apparently overriding style declarations) where the issue can be replicated, there is no bug to address here.

avatar brianteeman
brianteeman - comment - 2 Nov 2016

Without providing a sample extension or at a minimum a form definition (and apparently overriding style declarations) where the issue can be replicated, there is no bug to address here.

@joeforjoomla please respond to this request from @mbabker - otherwise this will have to be closed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12559.

avatar brianteeman brianteeman - change - 2 Nov 2016
Status New Information Required
avatar brianteeman brianteeman - edited - 2 Nov 2016
avatar brianteeman
brianteeman - comment - 14 Nov 2016

@joeforjoomla this will be closed in 7 days


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12559.

avatar brianteeman
brianteeman - comment - 9 Dec 2016

Kept it open for another month but as there has been no response there is no option but to close this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12559.

avatar brianteeman brianteeman - close - 9 Dec 2016
avatar brianteeman brianteeman - change - 9 Dec 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-12-09 12:28:17
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Dec 2016

Add a Comment

Login with GitHub to post a comment