[#12548] - fix less / css
- Fixed in Code Base
- 1 Nov 2016
- Medium
- Build: staging
- # 12548
- Diff
- brianteeman:fix_less_compile
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
recompile less using our generatecss.php script
Most changes seem to be codestyle - i guess someone used a different less compiler
BUT check the changes to input-prepend
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
zero-24
- | Milestone |
Added: |
||
Btw: https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/less/bootstrap-extended.less#L376-L383 doesn't look right (and is also related to the mentioned PR).
I have tested this item
@brianteeman Apologies as this was most likely my doing. Noted for future PRs! :)
@Bakual I emptied these selectors for #12442 . As empty selectors are ignored by LESS, I didn't bother removing them.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.
As empty selectors are ignored by LESS, I didn't bother removing them.
You should have, as empty selectors are useless
| Labels |
Added:
?
Removed: ? |
||
@zero-24 @bakual can you guys test this so we can get it merged and then other PRs wont be effected by this error
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.
I have tested this item
Tested with Protostar, Isis and my own template and couldn't see any notable difference.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.
dgt41
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-01 09:33:37 |
| Closed_By | ⇒ | rdeutz |
Thanks
| Labels |
Removed:
?
|
||
The input-prepend stuff is related to this PR that was merged lately: #12442