[#12546] - Use the JHtml::_ function instead of calling functions directly.
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 12546
- Diff
- okonomiyaki3000:use-jhtml-underscore
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Instead of calling JHtml static functions directly, call them with the underscore function like JHtml::_('functionname'); so that it's possible to override them.
Testing Instructions
The changed files could potentially affect many pages (for example, any list page with a disabled ordering column). You should see no difference before and after applying the patch.
Documentation Changes Required
No but, if there is some documentation for developers, it would be a good idea for that documentation to make it clear that JHtml static functions should not be called directly but invoked through the _ function.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components Media Manager |
| Category | Administration Components com_media | ⇒ | Administration com_banners com_categories com_contact com_content com_installer com_languages com_media com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates Components |
I have tested this item
Tested on Menu Item Category List and hidden Show Author. Page display same woth or without PR-
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12546.
@okonomiyaki3000 can you update your PR, it's out of sync, Thanks
Should be in sync now.
I have tested this item
Please check whether the operations performed meet the requirements for this test (newbee on testing)
On new installation PHP7.1.1 and Joomla! 3.7.0-beta2 dev [ Amani ] 2-February-2017 18:53 GMT:
- Added 5 contacts. Looked at the conact list. Reodered the list, changed the status and reordered it by status
- Applied the patch and did the same steps. No visal changes seen.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12546.
I have just fixed the conflicts. -> RTC
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 22:27:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
@mbabker tests have been reverted, please check.