[#12539] - Add profile link to login module
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12539
- Diff
- brianteeman:login
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The login module has links to creating an account and password/username reminders
The logout only has a greeting and a button
Summary of Changes
This PR add a link to the profile page in the logout view. Currently the only way to view your profile and optionaly edit that profile is if there is a dedicated menu link. This removes the need for that menu item and just adds it to the module
Testing Instructions
Apply the patch and login on the front end of your site and you will see the new option
Backwards Compatibility
Is adding a new link to the front end a break in B/C ? I dont know. If it is felt that it is then we could always add a parameter to the module to enable this link (it would therefore have to be disable by default) but I'd rather not add another param unless its felt its really required.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Language & Strings Modules Front End |
I can add the param if required
On 24 October 2016 at 21:03, Luca Marzo notifications@github.com wrote:
I like the opportunity to have a parameter that enables the link.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12539 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8T5frFJPuQ7M2SgOLyMK31FP-T_vks5q3Q8fgaJpZM4KfIKA
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
let's wait other opinions
looks good to me, add a param for show profile link with a default of false
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
OK I will work on adding the param
thanks @brianteeman
Param, language string and beez override added
The default is not to show the link so there is no B/C issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12539.
I have tested this item
Tested successfully at PBF NL
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12539.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12539.
| Category | Language & Strings Modules Front End | ⇒ | Language & Strings Modules Front End Templates (site) |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 09:34:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
Removed: ? |
||
I like the opportunity to have a parameter that enables the link.