@dgt41 this further extends the issue you were trying to resolve in #11970
As you can see the issue is more widespread

The problem (at least as I realize it) comes from the fact that modals don't have a menuid. The menuid is responsible for selecting the template so with this vital info missing joomla takes falls to whatever default is set on the renderer. There might be a way out with the registry, but this needs some serious debugging. @mbabker am I in the right track here, or this won't go anywhere?

Sounds valid. Tacking on either the Itemid or template query params would help it but it's still not the most efficient thing out there.

Any other ideas?o

The Itemid imho is the right approach. There should be no URL without Itemid generated at all because it generates exactly such issues.

You can't generate these URLs with Itemid though because these URLs aren't tied to the menu system so at best you're going to get the default menu item unless each of these URLs explicitly specifies the current menu item's ID when it builds these routes.

Why can't you use the current Itemid when generating the modal link? In frontend, each page should have one that you can use and it is most likely the one you would expect for the modal.

You still have to go in and change every instance where the route is being generated to work that way. The main point though is you shouldn't have to explicitly state a menu item ID for this stuff (or a template), but without doing so you're getting beyond the capabilities of our routing systems.

Why can't you use the current Itemid when generating the modal link? In frontend, each page should have one that you can use and it is most likely the one you would expect for the modal.

.

You still have to go in and change every instance where the route is being generated to work that way.

As always i dont care how its done but it does need to be done.

You still have to go in and change every instance where the route is being generated to work that way.

Yep.

Using current Itemid has side effects as router may add new url variables that are defined for that specific menu item, thus potentially altering the behaviour of the requested page. This is issue if the menu item xml specifies extra url variables which allow you to change behaviour of the view, like limiting items by category.

@mahagr the router in not used in these cases, all xtd-buttons are diverted to backend

@mbabker @Bakual setting a cookie with the template and itemId, might be another approach?

I just wanted to bring up potential side effects; if there are none, I stay corrected.

I find setting cookie dangerous as you can have multiple windows/tabs open in your browser.

Personally I would love to go and use Itemid (when its safe) whenever possible as I'd really love to get rid of direct access to the components in some distant future.

Please remember that it is the templatestyle not the template

On 25 October 2016 at 09:30, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@mbabker https://github.com/mbabker @Bakual https://github.com/Bakual
setting a cookie with the template and itemId, might be another approach?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12537 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Uy74bj2lDA57Yy-fR9tbgs6cdQxks5q3b4hgaJpZM4Ke-jJ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@dgt41 it is not just the xtd-buttons. Also all the links on edit forms
that open the media manager modals

On 25 October 2016 at 09:28, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@mahagr https://github.com/mahagr the router in not used in these
cases, all xtd-buttons are diverted to backend

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12537 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fqDC9kWcDHkVR752wcEx046f0Siks5q3b2ugaJpZM4Ke-jJ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

So long and farewell