Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12532] - [4.0] Deprecate JInput in favor of the Framework's Input package

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
23 Oct 2016

Summary of Changes

  • Extend JInput from Joomla\Input\Input
  • Deprecate JInput classes for the namespaced variants

Testing Instructions

Reading data from the request works still

Documentation Changes Required

Note deprecations

avatar mbabker mbabker - open - 23 Oct 2016
avatar mbabker mbabker - change - 23 Oct 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Oct 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 23 Oct 2016
Category ⇒ Libraries Unit Tests
avatar wilsonge
wilsonge - comment - 24 Oct 2016

Is it worth extending JInputCli from framework Cli (and the others too) instead of JInput? I can see pros and cons both ways..... unsure how many people will practically typehint JInput....

avatar mbabker
mbabker - comment - 24 Oct 2016

It breaks the typehints and some of the subclasses don't have feature parity. IMO this is the safest route.

avatar mbabker mbabker - change - 26 Oct 2016
Title
…
Deprecate JInput in favor of the Framework's Input package
[4.0] Deprecate JInput in favor of the Framework's Input package
avatar mbabker mbabker - edited - 26 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 29 Oct 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-10-29 20:52:59
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 29 Oct 2016
avatar wilsonge wilsonge - merge - 29 Oct 2016
avatar zero-24 zero-24 - close - 29 Oct 2016

Add a Comment

Login with GitHub to post a comment