@ciar4n nice!
Tested successfully but can't set the result in tracker

BTW I was screaming to use an override for chosen.css but everybody was against it...

@dgt41 what is wrong in the tracker?

Missing commit SHA?

I have tested this and it worked...

@mbabker can you take a look into the commit aha thing?

I can't say I like this fix but if it fixes it then whatever.

Tracker's fixed.

I have tested this item ✅ successfully on 3186e0b

RTC then

Actually this is kinda wrong as we remove retina support from default chosen.css. I still think that an override is the right approach here!

Do we have retina support everywhere else though?

@PhilETaylor this is a file from an external repo, we shouldn't mess with it in such way. Override is a clean approach

ah ok

These fields now use an icon font set which removes the need for a 2x image as the icons are now fully scalable.

@dgt41 I could override this CSS (instead of removing) in the template.css but that is just doubling up on un-needed CSS?

@mbabker Is your concern about the clarity on retina displays? This is no longer an issue with the font icons.

Also the file was already created and at some point it was decided to not include an override...
the file is here: https://github.com/joomla/joomla-cms/blob/381105ff2467abc3bddf77e7a2752d737c46f96f/administrator/templates/isis/css/jui/chosen.css

@dgt41 The chosen.css is now overridden within the Isis template.css rather than creating a separate chosen.css for the template. This was to allow for an easier upgrade of the chosen.css if needs be in the future.

@PhilETaylor Yes. As all chosen icons are now font based ensuring retina support and removes the need for 2x sprites.

@mbabker Is your concern about the clarity on retina displays? This is no longer an issue with the font icons.

At first glance it just seems like we're removing retina support. Admittedly my eyes aren't good enough to know what on earth the difference is for retina versus non-retina so it may be a non-issue.

@ciar4n just to clarify my point here:
you've been asked to do the override inside the template.css and you delivered that, I am not blaming you here. All I am pointing is that, that decision was wrong since we end up with bug and finally with the removal of the retina support for anyone that doesn't override the default chosen.css

A little explanation for those that are wondering..

3.6.x
Select fields (chosen.css) used an image for it's icons. As retina displays have a higher pixel density, a second larger image was required to avoid the icon looking pixelated compared to other vector based elements (text, divs etc) on the screen. This is the CSS that has been removed with this PR.

3.7.x
Select fields now use a font set for it's icons since #11832. As the icons are now vector based, they will resize without any loss of quality. There is no longer a need to define a different icon for each screen size. The reason this issue presented a number of icons was both the font based (retina ready) and the image based (retina ready) icon was loading. This PR removes the image based icon.

Conclusion
Basically the bottom line is these fields still completely supports retina displays, in fact more so than previously as higher resolution/density displays become available.

@dgt41 It is true that this CSS will also have to be removed from any further updates to chosen.css. Something that may be forgotten in the future. Guess we'll have to cross that hurdle when we get to it! :)

@dgt41 please clear your browser cache

@brianteeman ???

No idea why that message just came through. I wasn't even online 3hours ago

masses of @brianteeman emails came through to GH in one sweep about 3 hours ago - seems a GH issue

Weird

GitHub's email handler was on the fritz. Stuff I responded by email to
last week wasn't working and those messages showed up today.

On Tuesday, October 25, 2016, Brian Teeman notifications@github.com wrote:

Weird

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12528 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoW1ZTwNxLlV7rKfVBLsDw7x9VK_xks5q3nV3gaJpZM4KeKMt
.

mantainers please add 3.7.0 label here

@ciar4n

Guess we'll have to cross that hurdle when we get to it!

The time has come. ? I have a regression due to a fix overwrite. See #16552 and kindly confirm.

PS: @dgt41 was terribly right.

@ciar4n

Select fields now use a font set for it's icons since

1. Why the file media/jui/css/chosen-sprite@2x.png is still there?
2. And since it contains the same icons as chosen-sprite.png why this one is still there as well?
3. And why media/jui/css/chosen.css still contains a lot of references to 'chosen-sprite.png'?

@demis-palma can you do a new issue with that questions? Else this would get lost fast ;)

It's actually not an issue, a the moment it's a genuine question. I guess that there is a reason behind that, but I still don't understand what it is.

@demis-palma

If I remember correctly media/jui/css/chosen.css is untouched and is instead overridden by the template CSS where needed. So reference to the chosen-sprite is overridden by the template which replaces the sprite with a font set. Discussion on this can be found here... #11832 (comment)