[#12519] - [3.7] [regression] Article Blog layout
- Closed
- 25 Oct 2016
- Medium
- Build: master
- # 12519
Steps to reproduce the issue
Set article options for blog layout to 1 column and confirm that a menu item set to use the globals (ie no numbers entered in the column field) and check that the blog layout is in one column
Set article options for blog layout to 2 columns and confirm that a menu item set to use the globals (ie no numbers entered in the column field) and check that the blog layout is in two columns
Set the blog layout option in the menu item to 1 column
Expected result
After step 3 it should be in 1 column
Actual result
It is in 2 columns
Additional comment
Basically none of the blog layout settings at the menu level are overriding the settings at the component level
zero-24
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components Templates (site) |
| Labels |
Added:
?
|
||
Basically none of the blog layout settings at the menu level are overriding the settings at the component level
Confirmed.
It's actually not only the blog layout, it's everytime we merge component parameters with menu parameters, probably anytime we merge registry objects using registry_object->merge($another-registry-object).
I vaguely remember we had this issue once before.
There haven't been any changes in the Registry API to cause this.
@mbabker Found the culprit: #12395
Apparently registry->loadString() worked also when you passed a registry object, however directly creating the registry object with new Registry() doesn't work with a registry object (doesn't make much sense anyway). It will become some funny Registry->data->data.
See #12557
Closing as we have a PR.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-25 19:52:16 |
| Closed_By | ⇒ | Bakual |
I guess that would make sense since Registry has a __toString() method so it could be typecast by something either in the formatter API or the underlying PHP engine. Either way definitely makes no sense to take a registry, convert it to string, then convert it back.
It may be worth to check if there are similar cases in other places of your merged PR.
I'll see if I can take the time tomorrow to look over it.
Great that you found the cause
| Labels |
Removed:
?
|
||
I ran out of battery but I suspect the same is true for all options at the menu level
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12519.