[#12490] - Allow empty search - uses wrong value
- Fixed in Code Base
- 8 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 12490
- Diff
- brianteeman:smart_search
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12489
Steps to reproduce the issue
Create finder component page. Set to allow empty search. Display page mouse over search button. The search button is rendered as disabled (class contains 'disabled')
Expected result
search button should be rendered enabled, that is, the tag should not have class 'disabled'
Actual result
The search button is rendered as disabled (class contains 'disabled')
This was because
The parameter name used in components/com_finder/views/search/tmpl/default_form.php line 78 , allow_empty_search, should be 'allow_empty_query' to match the parameter field defined in administrator/components/com_finder/config.xml line 37.
This PR fixes that
Thanks to @nclifton for this fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Front End Components |
| Labels |
Added:
?
Removed: ? |
||
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12490.
Simple fix. Merging with one test and code review
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-08 23:25:18 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Category | Front End Components | ⇒ | Front End com_finder Components |
Thanks
I tested this PR.
You are right, die name of the parameter is wrong and your correction makes it right.
But the display of the button did not change for me. It looks active in all cases. Do we use the right syntax for boostrap 2 here? Shoudn’t it be
<button type="button" class="btn btn-large" disabled>Button</button>in the case of a button: http://getbootstrap.com/2.3.2/base-css.html#buttons