?
avatar Twincarb
Twincarb
20 Oct 2016

Steps to reproduce the issue

https://github.com/codemirror/CodeMirror/releases

Expected result

Latest version installed

Actual result

We are a couple of versions behind

System information (as much as possible)

Latest version is 5.20 we are currently using 4.18

Additional comments

avatar Twincarb Twincarb - open - 20 Oct 2016
avatar brianteeman
brianteeman - comment - 20 Oct 2016

We are currently on 5.18 in Joomla 3.6.3 and 5.19 was merged into Joomla 3.7 4 days ago see #12300

@okonomiyaki3000 does a great job in supplying the codemirror updates but of course because the codemirror release schedule doesnt match the Joomla release schedule there will always be differences

avatar brianteeman brianteeman - change - 20 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-20 12:02:49
Closed_By brianteeman
avatar brianteeman brianteeman - close - 20 Oct 2016
avatar Twincarb
Twincarb - comment - 20 Oct 2016

@okonomiyaki3000 Codemirror is now at version 5.20

@brianteeman my mistake saying we were still on 4.18 (I got the sub version right!) - version 5.20 was released today hence opening the new tracker, closing it before the latest staging is updated is slightly preemptive.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12488.

avatar brianteeman
brianteeman - comment - 20 Oct 2016

There is no need for this issue as @okonomiyaki3000 does a great job at
keeping it update

On 20 Oct 2016 1:39 p.m., "Twincarb" notifications@github.com wrote:

@okonomiyaki3000 https://github.com/okonomiyaki3000 Codemirror is now
at version 5.20

@brianteeman https://github.com/brianteeman my mistake saying we were
still on 4.18 (I got the sub version right!) - version 5.20 was released
today hence opening the new tracker, closing it before the latest staging

is updated is slightly preemptive.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/tracker/
joomla-cms/12488.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12488 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XWNHvIH2ndzvDsLi6xCu3dXsfOfks5q12DzgaJpZM4Kb_Be
.

avatar dgt41
dgt41 - comment - 20 Oct 2016

Just a heads up here, in joomla 4 there will be script that will automatically update all these libraries to their latest version

avatar brianteeman
brianteeman - comment - 20 Oct 2016

That's not confirmed at all and something that still needs to be fully
considered as there are consequences buy that is completely off topic here

avatar dgt41
dgt41 - comment - 20 Oct 2016

That's not confirmed at all

What do you mean? The code is already written and accepted

avatar brianteeman
brianteeman - comment - 20 Oct 2016

Where

On 20 Oct 2016 1:55 p.m., "Dimitri Grammatikogianni" <
notifications@github.com> wrote:

That's not confirmed at all

What do you mean? The code is already written and accepted


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12488 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WuX0UIHAgMhhaJbwTTdusIUYk5jks5q12SZgaJpZM4Kb_Be
.

avatar dgt41
dgt41 - comment - 20 Oct 2016

not public yet...

avatar mbabker
mbabker - comment - 20 Oct 2016

Nothing is final until it goes into a release. Even if it's already merged into a repo. How many pull requests have we all had changed or reverted?

avatar dgt41
dgt41 - comment - 20 Oct 2016

OK, lets ignore my initial comment here ?

avatar brianteeman
brianteeman - comment - 20 Oct 2016

So it is not accepted then if its not in the repo. And it won't be in J4
until J4 is released. That's the fact.

It is not beneficial at all to tell people that invisible feature x has
been accepted and will be in a release.

avatar dgt41
dgt41 - comment - 20 Oct 2016

@brianteeman this is a feature mainly for the project maintainers, so instead of manually d/l and replace tinyMCE, code mirror, etc this is done automatically
(personally I'm pretty sure it's gonna be accepted as it's enormously helpful and reduces the amount of work to keep things in sync. But as Micheal said, let's wait for the final version and the decision on that...)

avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Oct 2016

+1 @dgt41

also +1 for all automatizing repeative tasks in the future!

avatar brianteeman
brianteeman - comment - 20 Oct 2016

Massive difference between you thinking it's going to be accepted and your statement that it was already accepted.

Massive difference between code being merged into the repo automatically and code being merged into users sites automatically

avatar okonomiyaki3000
okonomiyaki3000 - comment - 20 Oct 2016

Thanks for the heads up about 5.20, I'll have a PR for it soon. Also interesting news about Joomla 4. That feature sounds awesome.

If there is any issue of people using an old version of Joomla and unable to upgrade for some reason but want to run a new version of codemirror, I can easily make an installable package of the latest version that should work with any Joomla above 3.0 (probably). With a little work, it could also work with older Joomlas.

In case anyone is interested, this is how I keep CodeMirror in Joomla up-to-date: https://github.com/okonomiyaki3000/joomla-codemirror-builder It seems that 5.20 has some interesting changes that may require an update to this script though.

Add a Comment

Login with GitHub to post a comment