[#12465] - More useful message when "Force HTTPS" config save fails (because of HTTPS config issues)
- Fixed in Code Base
- 10 Nov 2016
- Medium
- Build: staging
- # 12465
- Diff
- andrepereiradasilva:patch-10
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Since the current global config "Force HTTPS" warning message doesn't say much to user, this PR makes the message show the real problem.
Testing Instructions
- Use latest staging
- In a server with SSL config issues try to save joomla config as Forced HTTPS
- You will get a warning message like this
- Now apply this patch and test again. you will get a more useful warning message that says why the problem exists
Documentation Changes Required
None.
@brianteeman please check
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Components Language & Strings |
| Labels |
Removed:
?
|
||
@andrepereiradasilva to be able to test this PR, you need a server with SSL configuration issues.
Any idea how to create those issues
To create an issue do this:
- Apply this patch
- Go to https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/model/application.php#L137 and set this to
CURLOPT_PROXY => 'nohost.local', - Now try to change the site config to Force HTTPS
- It will fail and you will get something like this:
I have tested this item
Tested successfully.
The test instructions in the last message are the easiest way to create a not working HTTPS situation to be able to see the error message.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12465.
I have tested this item
Tested on Localhost:
Message:
HTTPS has not been enabled as it is not available on this server. HTTPS connection test failed with the following error: Failed to connect to localhost port 443: Connection refused
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12465.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12465.
| Labels | |||
zero-24
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-10 09:03:37 |
| Closed_By | ⇒ | rdeutz |
@andrepereiradasilva any ideas on creating config issues for HTTPS?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12465.