Thanks for making this.

Do you think the login box would be better as center aligned or even left aligned. On a large screen with it right aligned it might be missed

http://i.tee.mn/pfHP.png

The main problem I see is that this is not in staging...

@rdeutz
Shall we release 3.6.3 with this missing?

I am not merging something on release day, has to wait

@brianteeman
I just managed here to get the features. Did not look into the login box at all.
I guess we also have to override finaliseconfirm.php

We just need a center class in hathor that should do the trick ?

.center {
    text-align: center;
}

The same class is also used in the finaliseconfirm.php and the upload & install login pages.

That will not work in Hathor as the sliders design is quite different.
Looking into it now.

@brianteeman
@zero-24
Should work now. Please test again.
The login form will display float left on ltr sites, right on rtl.

I have tested this item ✅ successfully on 5867591

I have tested this item ? unsuccessfully on 5867591

Almost but not quite. It is not possible to select all the options for writing the files

screenshot showing the second option obscured and the third option invisible

Yes this needs to be fixed, but the cropping is not specific to this view,

it will happen to any select field inside the slider in any view, if the select is near the bottom

Pane slider has overflow hidden

<div class="pane-slider content pane-down" style="... overflow: hidden; ...">

Solution, either change globally to remove the overflow hidden, but this will have undesired effects, think of any frontend 3rd party views using the slider and relying on overflow hidden ...

i think it is best to change hathor template for "fieldset.uploadForm"
and add min-height to it

it will happen to any select field inside the slider in any view, if the
select is near the bottom

examples please

On 14 November 2016 at 21:49, Georgios Papadakis notifications@github.com
wrote:

Yes this needs to be fixed, but the cropping is not specific to this view,

it will happen to any select field inside the slider in any view, if the
select is near the bottom

Pane slider has overflow hidden

Solution, either change globally to remove the overflow hidden, but this
will have undesired effects, think of any frontend 3rd party views using
the slider and relying on overflow hidden ...

i think it is best to change hathor template for "fieldset.uploadForm"
and add min-height to it

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8W2hWwyGB7ym4mX_RSn20g8zK44Eks5q-NdQgaJpZM4KZmqp
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

it will happen to any select field inside the slider in any view, if the select is near the bottom

examples please

It was general comment, i do not have any examples now,
possibly no such views, because someone would have reported

so i think just fix this one case that we know about

thats my point. Comments like that kill changes without any justification.
Lets fix the issues we have without inventing mystical ones that might
appear if we are standing on one leg with the sun shining in the east

On 14 November 2016 at 21:56, Georgios Papadakis notifications@github.com
wrote:

it will happen to any select field inside the slider in any view, if the
select is near the bottom

examples please

It was general comment, i do not have any examples now,
possibly no such views, because someone would have reported

so i think just fix this one case that we know about

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Q-8VwejdrGnrp80Mnb7S03_FUm1ks5q-NkegaJpZM4KZmqp
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Comments like that kill changes without any justification.

ok, but which changes are being killed ? this PR ?
justification to stop what ? where ?
i really do not understand which comment was stopping something, and why it was being stopped

i simply said any view that uses slider (or any similar overflow-hidden container) and has a select near the bottom has this problem, Joomla or 3rd party view

about stopping changes

i did post a successful test,
i did not post an unsuccessful test
i did say that the cropping is not related to this PR,

so if someone wants to fix an issue here, that is not related to this PR,
then sure go ahead, i even suggested 1 way to do it

so i am little confused, about killing changes

Now about testing PRs,
is it preferable that people do not post feedback, ?

• especially feedback that explains instead of only reporting

is it preferable that people do not test the PRs ? and eventually people that created the PRs,

• close them after frustration of not having testers ?

and about the cropping effect i had faced it before a couple of times in my own views, and it is not the first time that it is mentioned in this tracker (i do not remember where)

select2 has solved both issues of overflow-hidden and the z-index+position in parent nodes,
by moving the drop-down list directly under the BODY tag, i am using it

To simplify, added min-height: 200px; to fieldset.uploadform as suggested.
We now get:

I have tested this item ✅ successfully on 74afe78

I have tested this item ✅ successfully on 74afe78

RTC