? Success

User tests: Successful: Unsuccessful:

avatar GeoTimber
GeoTimber
16 Oct 2016

Pull Request for Issue #12440

Summary of Changes

Comment on $week property was wrong

Testing Instructions

Documentation Changes Required

$week W - Numeric representation of the day of the week.
should be:
$week W - ISO-8601 week number of year, weeks starting on Monday

avatar GeoTimber GeoTimber - open - 16 Oct 2016
avatar GeoTimber GeoTimber - change - 16 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Category Libraries
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Oct 2016
avatar andrepereiradasilva andrepereiradasilva - test_item - 16 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Oct 2016

I have tested this item successfully on 682229d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12441.

avatar zero-24 zero-24 - test_item - 16 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Oct 2016

I have tested this item successfully on 682229d

On review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12441.

avatar zero-24 zero-24 - change - 16 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 16 Oct 2016

RTC for 3.6.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12441.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Oct 2016

Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release

avatar brianteeman
brianteeman - comment - 17 Oct 2016

To me the english is terrible and should be

$week W - ISO-8601 week number of year. Weeks start on Monday

But as its a copy/paste from the php manual I guess its ok

avatar brianteeman brianteeman - close - 18 Oct 2016
avatar rdeutz rdeutz - change - 18 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-18 17:46:21
Closed_By rdeutz
avatar rdeutz rdeutz - close - 18 Oct 2016
avatar rdeutz rdeutz - merge - 18 Oct 2016
avatar brianteeman brianteeman - change - 18 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment