[#12429] - [3.7.x] addScript corrections after 11289 merge
- Fixed in Code Base
- 16 Oct 2016
- Medium
- Build: 3.7.x
- # 12429
- Diff
- andrepereiradasilva:script-corrections
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for corrections to #11289.
Summary of Changes
This small PR corrects one thing missing from the #11289 merge. before the PR the default type was text/javascript, after the PR merge there is no deault type.
Also reinstates @mbabker JHtml::script() code review changes (https://github.com/joomla/joomla-cms/pull/10771/files#diff-b01d47e3fbe4a8e5fb4987f4df64b291R679) that was lost in merging conflicts.
Testing Instructions
Most of all code review.
But you can also test the following:
1. Use latests 3.7.x branch
2. Delete the $doc->setHtml5(true); line in /templates/protostar/index.php to set he document as non html5
3. Go to frontend and check code, you will notice the script tags have no type="text/javascript"attribute and they should as this document is not rendered as html5
4. Apply patch. check now they have the type="text/javascript"attribute as they should
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12429.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks @andrepereiradasilva
| Labels |
Added:
?
|
||
Thanks. Merging now
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-16 14:46:22 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
thanks for testing
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 5ee67be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12429.