? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
14 Oct 2016

Pull Request for Issue #12407

#11762 has deleted some files which were necessary for Hathor to display the Users Manager as well as the Modules manager.
This PR corrects the Hathor overrides default.php files to use the same code as in other managers using the batch function.

@RonakParmar @brianteeman @wilsonge

avatar infograf768 infograf768 - open - 14 Oct 2016
avatar infograf768 infograf768 - change - 14 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2016
Category Administration Templates (admin)
avatar infograf768
infograf768 - comment - 14 Oct 2016

Please set milestone to 3.7 and Release blocker

avatar RonakParmar RonakParmar - test_item - 14 Oct 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

I have tested this item successfully on 5907235


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12412.

avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

Now, com_users and com_modules working fine, see attached screen dumps.
screen shot 2016-10-14 at 00 20 25screen shot 2016-10-14 at 00 20 26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12412.

avatar wilsonge
wilsonge - comment - 14 Oct 2016

#11762 was merged into staging. So why is this PR for 3.7.x?

avatar brianteeman
brianteeman - comment - 14 Oct 2016

@wilsonge because you correctly merged it into 3.7 branch
see screenshot http://i.tee.mn/CzI1.png

avatar infograf768
infograf768 - comment - 20 Oct 2016

This needs one more tester and milestone set to 3.7.0

avatar Webdongle Webdongle - test_item - 28 Oct 2016 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 28 Oct 2016

well, this means we need more, but the pr already solves the access to 2 managers.

avatar Webdongle
Webdongle - comment - 28 Oct 2016

But it does not solve #12607 which was closed as being a duplicate of this tracker. Either #12607 needs to be fixed in this patch or it needs to be re-opened. Which is it please ?

Addendum
#12607 has been reopened ... I have deleted my previous test and retested based on this tracker alone. Pass

avatar Webdongle Webdongle - test_item - 28 Oct 2016 - Tested successfully
avatar Webdongle
Webdongle - comment - 28 Oct 2016

I have tested this item successfully on 5907235

Re tested and Full Success based on the criteria of this tracker


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12412.

avatar infograf768 infograf768 - change - 28 Oct 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 29 Oct 2016

RTC. Thanks for testing.

@rdeutz

Thanks for merging as we have some more to do here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12412.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 29 Oct 2016
avatar rdeutz rdeutz - merge - 29 Oct 2016
avatar wilsonge wilsonge - close - 29 Oct 2016
avatar rdeutz rdeutz - reference | f1c6878 - 29 Oct 16
avatar rdeutz rdeutz - merge - 29 Oct 2016
avatar rdeutz rdeutz - close - 29 Oct 2016
avatar zero-24 zero-24 - close - 29 Oct 2016
avatar rdeutz rdeutz - change - 29 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-29 08:49:07
Closed_By rdeutz
avatar zero-24 zero-24 - change - 29 Oct 2016
Labels Removed: ?
avatar wilsonge wilsonge - reference | 27c090e - 29 Oct 16
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Nov 2016

missing 3.7.0 milestone here

avatar wilsonge wilsonge - change - 3 Nov 2016
The description was changed
avatar wilsonge wilsonge - change - 3 Nov 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 3 Nov 2016

Thanks

Add a Comment

Login with GitHub to post a comment