? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Oct 2016

Pull Request for Issue #12404 .

Create a module for Articles-Latest
In Extensions->Manage find the module and disable it
Return to the module manager and you will see that the Article-Latest module now has an icon to display it is disabled and a tooltip "This module is disabled. Use Extensions => Manage to enable it."
Go to templates->style and select Hathor as your admin template
Return to the module manager and you will see that the Article-Latest module does NOT have an icon to display it is disabled and it has an incorrect tooltip "Extension enabled."

Apply the patch and you will the correct icon and message

avatar brianteeman brianteeman - open - 12 Oct 2016
avatar brianteeman brianteeman - change - 12 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2016
Category Administration Templates (admin)
avatar RonakParmar
RonakParmar - comment - 13 Oct 2016

I have downloaded Joomla_3.7.0-dev-Development-Full_Package.zip from this site https://developer.joomla.org/nightly-builds.html and setup in my local to test this PR,but with Hathor template I am not able to access module listing page at administrator side. Please see attached screen dump.
Joomla! Version : Joomla! 3.7.0-dev Development [ Noether ] 27-June-2016 08:13 GMT , Please let me know if I am doing anything wrong.

screen shot 2016-10-12 at 23 13 07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12405.

avatar brianteeman
brianteeman - comment - 13 Oct 2016

I can confirm that bug - which is unrelated to this PR but does mean you cant test it

avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

To test this PR I have to apply #12412 this PR, otherwise I have 500 (above) error page in module list page with Hathor template.
SO, What I have done, I have applied #12412 and then trying to apply this PR (#12405), but not able to apply this PR, having conflict issue.
Please see attached screen dump of error message.
screen shot 2016-10-14 at 00 30 43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12405.

avatar mbabker
mbabker - comment - 14 Oct 2016

That's expected behavior. As explained elsewhere, patch tester doesn't actually patch files, rather it downloads the files from the remote branch of a pull request and replaces them. So it cannot "patch" the same file from multiple pull requests.

avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

I have to manually apply changes of #12412 and then I have to apply this PR, correct?

avatar mbabker
mbabker - comment - 14 Oct 2016

Honestly, you probably need to use a git client if you are trying to apply both of those patches which touch the same file. Or wait for #12412 to be merged then you can apply this one without an issue.

The other option is you create a branch on your repo, merge these two patches into that branch, open a PR on your repo with that combined set, and tell patch tester to pull PRs from your repo to apply that one.

avatar RonakParmar RonakParmar - test_item - 14 Oct 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

I have tested this item successfully on 7fa9714


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12405.

avatar RonakParmar
RonakParmar - comment - 14 Oct 2016

Thank you for the tip.
I have applied this PR and manually changed modules default.php file in Hathor template.
Added below code in that file in place of load batch template code, and this PR works fine.
Please correct me if I have done anything wrong.

<?php // Load the batch processing form if user is allowed ?>
<?php if ($user->authorise('core.create', 'com_users')
&& $user->authorise('core.edit', 'com_users')
&& $user->authorise('core.edit.state', 'com_users')) : ?>
<?php echo JHtml::(
'bootstrap.renderModal',
'collapseModal',
array(
'title' => JText::
('COM_USERS_BATCH_OPTIONS'),
'footer' => $this->loadTemplate('batch_footer')
),
$this->loadTemplate('batch_body')
); ?>
<?php endif;?>

avatar brianteeman brianteeman - change - 29 Oct 2016
Labels Added: ?
Removed: ?
avatar brianteeman brianteeman - change - 4 Nov 2016
Easy No Yes
avatar brianteeman brianteeman - edited - 4 Nov 2016
avatar RickR2H
RickR2H - comment - 4 Nov 2016

@brianteeman we tested this successful but we can't submit a success from issues.joomla.org. Can you fix the merge conflict? Thanks!

avatar microtribe microtribe - test_item - 13 Nov 2016 - Tested successfully
avatar microtribe
microtribe - comment - 13 Nov 2016

I have tested this item successfully on 7fa9714

I tested this item and confirmed the problem by following the steps to create a module>articles-latest and testing the problem with Hathor. I manually applied the patch, and tested, and the problem was resolved - the article-latest module does have the icon to show disabled.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12405.

avatar brianteeman brianteeman - alter_testresult - 14 Nov 2016 - RickR2H: Tested successfully
avatar brianteeman
brianteeman - comment - 17 Nov 2016

I am closing this as I recreated it at #12925

I must learn how to resolve merge conflicts correctly

avatar brianteeman brianteeman - change - 17 Nov 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-17 11:04:20
Closed_By brianteeman
avatar brianteeman brianteeman - close - 17 Nov 2016

Add a Comment

Login with GitHub to post a comment