You can save a second redirect by changing from https://help.joomla.fr/3 to https://help.joomla.fr ?

BTW what's the source for this stuff? https://help.joomla.fr/index.php?option=com_help&keyref=Help36:Start_Here loads a page for 3.2...

@mbabker removed the second redirect

Any change for this link has also to be done through the VPN as the Refresh button would imho get it back from there.

BTW what's the source for this stuff? https://help.joomla.fr/index.php?option=com_help&keyref=Help36:Start_Here loads a page for 3.2...

Indeed, the French community made its own help site at the time as docs was only providing it in English. It has not been updated since.
In fact, just tested and if one chooses default help and set backend language to French, one still gets English help.

Note: although the French help is displaying fine when using the help button, it does not here when using index.php?option=com_admin&view=help
Here I get an error:
Load denied by X-Frame-Options: https://help.joomla.fr/index.php?option=com_help&keyref=Help36:Components_Banners_Categories_Edit does not permit cross-origin framing.(unknown)

I assume you mean https://update.joomla.org/helpsites/helpsites.xml because this controller is the only place in core I could find referencing anything off-site for that (which BTW should be converted to use the JHttp API).

In fact, just tested and if one chooses default help and set backend language to French, one still gets English help.

Core bug? Open your browser's network inspection tab and see what it's requesting; if it isn't appending the language code to the keyref value or adding a lang key then the proxy won't look for a translated page.

Load denied by X-Frame-Options

Get in touch with whomever is running that service, seems they need to tweak their server configuration to let things work correctly.

I'll answer the "still seeing English" part for you.

JHelp::createUrl() is what's used to build these URLs, it looks for certain placeholders to replace with values in the URLs (look in the method for the full list). None of the placeholders for language support are there. In fact, there is only one place in core adding the lang variable to the URL and that's AdminModelHelp::getLatestVersionCheck(). So the XML needs to be updated to include the relevant placeholders so that language codes can be included and the backend help gets localized.

And our server will explicitly check for conditions where there isn't a localized page for a language and fall back onto English. See the help screen model from the app's repo (mainly the getPage() method). I've explicitly tested both methods of passing language codes in and the fallback routine is fine (test out https://help.joomla.org/proxy/index.php?keyref=Help36:Start_Here&lang=fr and https://help.joomla.org/proxy/index.php?keyref=Help36:Start_Here/ar as examples).

@mbabker
I was using VPN.joomla.org at the time and a specific update FTP to place this (No need to give more details here). I honestly don't remember well where.

Concerning the help loaded when in backend using fr-FR lang and default core joomla help, I do not get the lang variable at all.

We've got that XML file at https://github.com/joomla/update.joomla.org/blob/master/www/helpsites/helpsites.xml so whenever this PR is merged someone can make a PR there and it'll get deployed up.

If we want to address the untranslated help, the English site can be changed to this definition and it should work:

<site tag="en-GB" url="https://help.joomla.org/proxy?keyref=Help{major}{minor}:{keyref}&amp;lang={langcode}">English (GB) - Joomla help wiki</site>

from ipad
if thedefault help is corrected, no use to prpose anymore the custom french one imho
will let this topic known to the french community asap

@mbabker
Although using <site tag="en-GB" url="https://help.joomla.org/proxy?keyref=Help{major}{minor}:{keyref}&amp;lang={langcode}">English (GB) - Joomla help wiki</site> does help get some stuff in French, there is not much there yet.

It is nevertheless a bug and necessary improvement. It should be solved both in core and in https://github.com/joomla/update.joomla.org/blob/master/www/helpsites/helpsites.xml

To test one has to enter the url in configuration.php:
public $helpurl = 'https://help.joomla.org/proxy?keyref=Help{major}{minor}:{keyref}&lang={langcode}';

Therefore I think the French help is still necessary for the moment although some of it is obsolete.

Note: some of the English help is also obsolete.

I made a PR towards update.joomla.org.
@Brianteeman
Can you add here the changes to get <site tag="en-GB" url="https://help.joomla.org/proxy?keyref=Help{major}{minor}:{keyref}&amp;lang={langcode}">English (GB) - Joomla help wiki</site>

And then we can merge this in 3.6.3

@infograf768 done

Looks like test have to be updated to please Travis
1) JFormFieldHelpsiteTest::testGetInput
etc.

@brianteeman
Looks like a very simple change to please travis

I am not touching tests as I have zero knowledge of how that works. So if
someone can please do a PR against my branch to fix that then I will merge
it

On 13 October 2016 at 10:03, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
Looks like a very simple change to please travis

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12400 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fs08gmMFo-QquQW5Vj06RYpvWbmks5qzfPegaJpZM4KUxvW
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

here it is
brianteeman#12

@infograf768 merged it - lets see

For 3.6.3

RTC

@rdeutz

Thanks