[#12380] - PHP Deprecated notice on restore.php Akeeba_Services_JSON
- Closed
- 12 Oct 2016
- Medium
- Build: master
- # 12380
Steps to reproduce the issue
run PHP -l against the CMS or see https://travis-ci.org/joomla/joomla-cms/jobs/166466458
Expected result
No PHP Deprecated error
Actual result
PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; Akeeba_Services_JSON has a deprecated constructor in ./administrator/components/com_joomlaupdate/restore.php on line 263
PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; Akeeba_Services_JSON_Error has a deprecated constructor in ./administrator/components/com_joomlaupdate/restore.php on line 925
Additional comments
Or should this be considered as 3party code that can be ignored?
is there a upstream for restore.php?
Wherever Nic takes reports on that stuff?
On Monday, October 10, 2016, zero-24 notifications@github.com wrote:
is there a upstream for restore.php?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12380 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSF9uqVkAJiRdRVObx4MnB1FZz6hks5qymCMgaJpZM4KSuGn
.
Hmm i cant find a upstream repo for the restore.php maybe @nikosdion can take a look here ;)
I had actually already removed that class from restore.php. Please find attached the latest build of Akeeba Restore. If you want me to make a PR with it instead let me know.
FWIW this class was not really used. It would only be used if you were to run Joomla! Update on a server which doesn't support json_encode / json_decode. That was a remnant of the Joomla! 1.6 era where it was actually possible to run Joomla! without JSON support in PHP. This has not been the case for years so I removed that class a couple of months ago.
brianteeman
- | Labels |
Added:
?
|
||
Closing as we have a PR
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-12 16:01:19 |
| Closed_By | ⇒ | wilsonge |
Report it upstream, ignore it in our linter.