? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Oct 2016

Pull Request for Issue #11616

PR for the files and folders identified by @jsubri as not present in current release and should be removed on update

avatar brianteeman brianteeman - open - 10 Oct 2016
avatar brianteeman brianteeman - change - 10 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2016
Category Administration Components
avatar jsubri
jsubri - comment - 10 Oct 2016

Brian, this is excellent, I've performed the upgrade scenario as per the original issue.
This PR can go as is in 3.6.3 let me know if you want a success via issues.joomla.org

On disk I've "couple of left over" see below, may be for an another PR.

// left over
// Joomla 3.4.1
media/editors/codemirror/lib/addons-uncompressed.js
media/editors/codemirror/lib/codemirror-uncompressed.css
media/editors/codemirror/lib/codemirror-uncompressed.js

// Joomla 3.4.2
administrator/templates/hathor/html/com_categories/categories/default_batch.php
administrator/templates/hathor/html/com_tags/tags/default_batch.php
media/editors/codemirror/mode/clike/scala.html
media/editors/codemirror/mode/css/less.html
media/editors/codemirror/mode/css/less_test.js
media/editors/codemirror/mode/css/scss.html
media/editors/codemirror/mode/css/scss_test.js
media/editors/codemirror/mode/css/test.js
media/editors/codemirror/mode/gfm/test.js
media/editors/codemirror/mode/haml/test.js
media/editors/codemirror/mode/javascript/json-ld.html
media/editors/codemirror/mode/javascript/test.js
media/editors/codemirror/mode/javascript/typescript.html
media/editors/codemirror/mode/markdown/test.js
media/editors/codemirror/mode/php/test.js
media/editors/codemirror/mode/ruby/test.js
media/editors/codemirror/mode/shell/test.js
media/editors/codemirror/mode/slim/test.js
media/editors/codemirror/mode/stex/test.js
media/editors/codemirror/mode/textile/test.js
media/editors/codemirror/mode/verilog/test.js
media/editors/codemirror/mode/xml/test.js
media/editors/codemirror/mode/xquery/test.js

// Joomla 3.6.1
libraries/joomla/database/iterator/azure.php
media/editors/tinymce/skins/lightgray/fonts/icomoon.eot

// Joomla 3.6.3RC2
// cd729d3
media/mod_languages/images/km_kr.gif

avatar brianteeman
brianteeman - comment - 10 Oct 2016

OK let me add those

On 10 October 2016 at 16:13, Jean-Luc Subri notifications@github.com
wrote:

Brian, this is excellent, I've performed the upgrade scenario as per the
original issue.
This PR can go as is in 3.6.3 let me know if you want a success via
issues.joomla.org

On disk I've "couple of left over" see below, may be for an another PR.

// left over
// Joomla 3.4.1
media/editors/codemirror/lib/addons-uncompressed.js
media/editors/codemirror/lib/codemirror-uncompressed.css
media/editors/codemirror/lib/codemirror-uncompressed.js

// Joomla 3.4.2
administrator/templates/hathor/html/com_categories/
categories/default_batch.php
administrator/templates/hathor/html/com_tags/tags/default_batch.php
media/editors/codemirror/mode/clike/scala.html
media/editors/codemirror/mode/css/less.html
media/editors/codemirror/mode/css/less_test.js
media/editors/codemirror/mode/css/scss.html
media/editors/codemirror/mode/css/scss_test.js
media/editors/codemirror/mode/css/test.js
media/editors/codemirror/mode/gfm/test.js
media/editors/codemirror/mode/haml/test.js
media/editors/codemirror/mode/javascript/json-ld.html
media/editors/codemirror/mode/javascript/test.js
media/editors/codemirror/mode/javascript/typescript.html
media/editors/codemirror/mode/markdown/test.js
media/editors/codemirror/mode/php/test.js
media/editors/codemirror/mode/ruby/test.js
media/editors/codemirror/mode/shell/test.js
media/editors/codemirror/mode/slim/test.js
media/editors/codemirror/mode/stex/test.js
media/editors/codemirror/mode/textile/test.js
media/editors/codemirror/mode/verilog/test.js
media/editors/codemirror/mode/xml/test.js
media/editors/codemirror/mode/xquery/test.js

// Joomla 3.6.1
libraries/joomla/database/iterator/azure.php
media/editors/tinymce/skins/lightgray/fonts/icomoon.eot

// Joomla 3.6.3RC2
// cd729d3
cd729d3
media/mod_languages/images/km_kr.gif


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fX6fiD59bpsXSFQsF8yiRu1jJm4ks5qylYEgaJpZM4KSgjP
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 10 Oct 2016

Added that last batch

avatar brianteeman
brianteeman - comment - 10 Oct 2016

I ignored that one on purpose as it was only in an RC

On 10 October 2016 at 16:45, Jean-Luc Subri notifications@github.com
wrote:

@jsubri commented on this pull request.

I've reverted the patch with patchtest, reset, re-applied the PR. the only
left over is media/mod_languages/images/km_kr.gif which is not shipped
with 3.6.3RC2


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cs5sjAZ_Ou9C55_S9LK6Kh-2FNrks5qyl19gaJpZM4KSgjP
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar jsubri jsubri - test_item - 10 Oct 2016 - Tested successfully
avatar jsubri
jsubri - comment - 10 Oct 2016

I have tested this item successfully on 79c830e

Tested successfully as indicated above. Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12378.

avatar jeckodevelopment jeckodevelopment - test_item - 10 Oct 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 10 Oct 2016

I have tested this item successfully on 79c830e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12378.

avatar jeckodevelopment jeckodevelopment - change - 10 Oct 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 10 Oct 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12378.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 12 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-12 10:29:59
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Oct 2016
avatar wilsonge wilsonge - merge - 12 Oct 2016
avatar zero-24 zero-24 - close - 12 Oct 2016
avatar zero-24 zero-24 - change - 12 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment