@PhilETaylor @ggppdk @mbabker can you also check and confirm this will solve the js browser cache on update problem.

so ... still no volunteers to review and/or test this?

Once we are over the release I am planning to test

On 20 October 2016 at 00:07, andrepereiradasilva notifications@github.com
wrote:

so ... still no volunteers to review and/or test this?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12373 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R9ZdykQfLsdKnsYvE-aA9aKt6smks5q1rDbgaJpZM4KSGTs
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

If I forget please remind me

On 20 October 2016 at 00:31, Brian Teeman brian@teeman.net wrote:

Once we are over the release I am planning to test

On 20 October 2016 at 00:07, andrepereiradasilva <notifications@github.com

wrote:

so ... still no volunteers to review and/or test this?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12373 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R9ZdykQfLsdKnsYvE-aA9aKt6smks5q1rDbgaJpZM4KSGTs
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

pinging @brianteeman

Thanks for the ping - I will test tomorrow

Am I correct in thinking that with this PR every css and js file should have a version string? If that is correct then this PR is not working correctly

For example go to administrator/index.php?option=com_content
and check all the css and js files being loaded

None of the css files in the /media/jui/css folder have version strings but everything else seems to

I am seeing the same behaviour in other pages I have checked such as administrator/index.php?option=com_media
Again none of the css files in the following folders have version strings
/media/jui/css folder
/media/media/css folder
/media/system/css

And on /administrator/index.php
Everything has version strings except for
/media/plg_quickicon_extensionupdate/js/extensionupdatecheck.js

Awaiting clarification if they are supposed to have version strings before continuing testing

CSS not yet. only JS for now

For CSS we still have a long way:
1. First this (#12375) needs to be proper tested and merged
2. Them we need to make a similiar PR to this, but for CSS

/media/plg_quickicon_extensionupdate/js/extensionupdatecheck.js

this one is probably a later merge (after this PR was done that did not used the new method signature)
will check

CSS not yet. only js
that was confusing as i see all the other css with version strings - sorry

How can I test that the version strong changes?

that was confusing as i see all the other css with version strings - sorry

Yes, the ones that used the JDocument::addStyleSheetVersion() (https://github.com/joomla/joomla-cms/search?q=addStyleSheetVersion), normally only the template files uses this.

How can I test that the version strong changes?

The fastst way to test this is:
1. make a code review
2. navigate joomla frontend, backend, installation pages with chrome dev bar open (Network tab -> JS) and check all js are loaded with version strings.

See this video:

Anyway there is no big issue with one or another js not adding the js string those can be corrected later.

How can I test that the version string changes?

Sorry I wasnt clear. I meant how can I test that the string itself will change when we want it to

oh in update? it that what you mean?

yes - how can i simulate a change so that I can ensure that the strings are updated - otherwise they are just meaningless strings ;)

The auto media version string is build with the getLongVersion, so if you have a different joomla version. See https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/version/version.php#L244.

To real test it i think you need to change joomla to some other version.
Let me check a easy way to do this...

Do this:
1. download https://github.com/joomla/joomla-cms/releases/download/3.6.4/Joomla_3.6.3_to_3.6.4-Stable-Patch_Package.zip
2. Go to admin, check the page source and the version string we are using before the update.
3. Them use that zip in Upload & Update in joomla update component
4. Check the page source and notice the version string changed, so from a browser eprspective they are different files, so the browser will not load them from cache.

ok @brianteeman updated the PR to include the ones added in latest merges.

@dgt41 can you also review test this so it can fgo in 3.7.0 and start avoiding js cache browser issues on update (like the one in modules recently ...)?

I have tested this item ✅ successfully on 1e2ccee

On Review and testing front end - back end random pages.

Can you remove this file from thePR
joomla-cms/layouts/joomla/layouts - Atalho.lnk

@brianteeman removed the file and the empty line

Thanks. Will try to find time to test again soon

Applied the PR and there is now a query string on all JS
in my case a123aee48ee7c097706e58056b57f833

BUT
Increased Joomla version in version.php and the string did NOT change

Do this:
1. download https://github.com/joomla/joomla-cms/releases/download/3.6.4/Joomla_3.6.3_to_3.6.4-Stable-Patch_Package.zip
2. Go to admin, check the page source and the version string we are using before the update.
3. Them use that zip in Upload & Update in joomla update component
4. Check the page source and notice the version string changed, so from a browser eprspective they are different files, so the browser will not load them from cache.

I have tested this item ✅ successfully on a7d4452

@dgt41 can you just marked as tested again (or test again the latests changes if you feel the need) so we can finnaly put this RTC?

I have tested this item ✅ successfully on a7d4452

RTC
@rdeutz @wilsonge can you merge this before it goes out of sync again?

thanks!