[#12369] - [plg_recaptcha] Check if can show captcha error messages
- Fixed in Code Base
- 17 Apr 2017
- Medium
- Build: staging
- # 12369
- Diff
- piotr-cz:bugfix/recapcha-error-handling
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue -.
This is updated PR of #9305.
Captcha API may not return any error codes for failed check.
In this case the JRecaptcha::verifyResponse doesn't return an array of error codes but an empty string (see https://github.com/joomla/joomla-cms/blob/3.6.2/plugins/captcha/recaptcha/recaptchalib.php#L142) and we get a PHP warning:
Warning: Invalid argument supplied for foreach() in [joomla]/plugins/captcha/recaptcha/recaptcha.php on line 205
Summary of Changes
Checking if response error codes format is an array.
Testing Instructions
I'm not sure how to trigger a recaptcha error without an error code, if I find out I'll update the testing intructions.
For now please do code review
Documentation Changes Required
none
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
zero-24
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
other possible fix is to make $errorCodes property as an array by default
class JReCaptchaResponse
{
public $success;
public $errorCodes = array();
}
@Fedik yes, that would be even better solution, few lines above errorCodes property is used to store a string.
@piotr-cz will you be updating this PR with @fedik suggestion?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12369.
@brianteeman it is fine as it is,
my suggestion can have small B/C issue, it is more safe as @piotr-cz made
Thanks for clarifying that I think people were waiting for an update before doing a code review
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-17 14:11:24 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 636bdc5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12369.