[#12355] - [com_joomlaupdate] Check for minimum supported database type and version
- Fixed in Code Base
- 18 Oct 2016
- Medium
- Build: staging
- # 12355
- Diff
- zero-24:database_minimum
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12351
Summary of Changes
This implements a minimum database feature into com_joomlaupdate so we can check for minimum supported database version per type
Testing Instructions
First Please review the code.
Test the Core
- Install 3.7.x (https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
- set this as custom update server
http://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml - confirm that com_joomlaupdate still points to 3.7.0-dev2
- apply this patch
- confirm that com_joomlaupdate still points to 3.7.0-dev2
- Do NOT install this update
- change the custom update server to
http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml - confirm that you get the
We can't find a download URL ....message in com_joomlaupdate - change the custom update server to
http://www.jah-tz.de/downloads/core/nightlies/next_minor_list3.xml - confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)
Test Extensions
- install 3.7.x (https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
- install an older component of choice e.g. JCE
- confirm that the update show and run as expected
- install this custom component (http://www.jah-tz.de/downloads/download.php?file=plg_dbminimum.zip&folder=core/extensions/plg_dbminimum/)
- confirm that it adds this update server
http://www.jah-tz.de/downloads/core/extensions/plg_dbminimum/plg_dbminimum.xml(see: Backend -> Extensions -> Manage -> Update Sites) - Try to update to the next version (0.0.2)
- confirm that you got a error message
Documentation Changes Required
Document the new tag if implemented as this can also be used by 3party extensions
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Language & Strings Libraries |
Tried to test this but at this point
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
confirm that you get the You don't support the minimum .... message in com_joomlaupdate
I get the "We can't find a download URL" message
@brianteeman yes this is the correct message. On writing the instructions i did not had the title in my mind.
confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)
Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?
i have just fixed the instructions thanks!
Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?
99.5.3 is used in test 2. ;) -> The reason you don't get the update
The 3. is just a test to make sure nothing breaks and you get the update if you meat the requirements
Extension update. The message I get is
This is confusing - the first sentence will lead me to think that the problem is that I can not connect to the update server
OK - all good then. - But they are warnings - should they be errors?
Also I missed a typo
On 8 October 2016 at 21:55, zero-24 notifications@github.com wrote:
That are 2 different errors ;) The first one is from the test report
extension (see: #12258 #12258)
and the seccond warning is my warning so everything works as expected.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RfrxpHDyULUFVikbhfo-MY97sKGks5qyANDgaJpZM4KR0KZ
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
OK - all good then.
Thanks!
But they are warnings - should they be errors?
I can do both i have set is at warning as the PHP Minimum message is also just a warning.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.
OK - I am not bothered myself if its a warning or error
On 8 October 2016 at 22:02, zero-24 notifications@github.com wrote:
OK - all good then.
Thanks!
But they are warnings - should they be errors?
I can do both i have set is at warning as the PHP Minimum message is also
just a warning.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8afmto0MtIZdiV3nmn-bYOdGgGWmks5qyATJgaJpZM4KR0KZ
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
Removed: ? |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-18 17:42:43 |
| Closed_By | ⇒ | rdeutz |
Thanks!
| Labels |
Removed:
?
|
||
I have just added the option supported_databases to this doku: https://docs.joomla.org/Deploying_an_Update_Server
Thanks fixed @brianteeman