User tests: Successful: Unsuccessful:
Pull Request for Issue #12343
A PR for any issues with the 3.7 Isis flat repaint (#11832). Currently removes text-shadows and fixes the mouseover on modal save button. Any other noticed issues, feel free to mention them in the comments.
Apply patch and check that all text has text-shadow removed
Open an existing menu item (Single Article). Click edit on the 'Select Article' field. Hover over 'Save'
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Labels |
Added:
?
|
Thank you @andrepereiradasilva
Changed to individual removal of text-shadow which resolves this.
also notice some gray model Close/Cancel buttons mouseover border is blue. not surre again if related to the isis flat repaint
Thanks again @andrepereiradasilva
All template related. All buttons should now hover in the correct state with the latest commit.
Thank you @andrepereiradasilva although I just put some finishing touches on the work started by @dgt41
For some it may take a little getting use to but I think in time even they will appreciate the cleaner UI.
Well spotted. I have re-aligned the permissions dropdown in the latest commit.
Thank you @andrepereiradasilva although I just put some finishing touches on the work started by @dgt41
ok so nice work @dgt41 too!
did you manage to check this?
also notice some gray model Close/Cancel buttons mouseover border is blue. not surre again if related to the isis flat repaint
@andrepereiradasilva Could you detail how to replicate this issue? Unable to find an example in Chrome or FF.
Also noticed that some buttons text on mouseover get dark blue, some don't change the text color (this is the expected i think).
This is part of the modals CSS which is loaded separately from the template. Probably best for a separate PR as there is a few changes that could be made. Just waiting to see the outcome of the improved media manager.
ok then
I have tested this item
as comments above
Also noticed that some buttons text on mouseover get dark blue, some don't change the text color (this is the expected i think).
Where? All places i found look good to me also on mouseover
I have tested this item
@andrepereiradasilva please double check if that works we can set this RTC
@zero-24 reggarding that @ciar4n responded
This is part of the modals CSS which is loaded separately from the template. Probably best for a separate PR as there is a few changes that could be made. Just waiting to see the outcome of the improved media manager.
So i ignore that and tested this with success
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
Labels |
Added:
?
|
don't know if this is a patchtester issue or the isis flat repaint
Just for reference the only custom CSS the patch tester uses is GitHub's octicons, and only for the GitHub logo. Otherwise everything is themed entirely by the templates (even the Hathor overrides have no custom style rules).
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-13 20:41:05 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
there are some text shadows left, we can hardly notice but they are there
Check this elements css and you will notice the

text-shadow
there.as for the rest. all fine