? Failure

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
8 Oct 2016

Pull Request for Issue #12343

Summary of Changes

A PR for any issues with the 3.7 Isis flat repaint (#11832). Currently removes text-shadows and fixes the mouseover on modal save button. Any other noticed issues, feel free to mention them in the comments.

Testing Instructions

Apply patch and check that all text has text-shadow removed

Before Patch
remove-shadow1

After Patch
remove-shadow2

Open an existing menu item (Single Article). Click edit on the 'Select Article' field. Hover over 'Save'

Before Patch
modal-save1

After Patch
modal-save2

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 8 Oct 2016
avatar ciar4n ciar4n - change - 8 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2016
Category Administration Templates (admin)
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2016
Labels Added: ?
avatar ciar4n ciar4n - change - 8 Oct 2016
The description was changed
avatar ciar4n ciar4n - edited - 8 Oct 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

there are some text shadows left, we can hardly notice but they are there

Check this elements css and you will notice the text-shadow there.
image

as for the rest. all fine

avatar ciar4n
ciar4n - comment - 8 Oct 2016

Thank you @andrepereiradasilva

Changed to individual removal of text-shadow which resolves this.

avatar ciar4n
ciar4n - comment - 8 Oct 2016

Thank you @dgt41 . Amended.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

don't know if this is a patchtester issue or the isis flat repaint, but look at the mouseover in this buttons
image

As for the rest is looks good

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

also notice some gray model Close/Cancel buttons mouseover border is blue. not surre again if related to the isis flat repaint

avatar ciar4n
ciar4n - comment - 8 Oct 2016

Thanks again @andrepereiradasilva

All template related. All buttons should now hover in the correct state with the latest commit.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

have to say @ciar4n nice work! really love this flat design. much better IMO!

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

again not sure if related to this but look at the permissions tab
image

avatar ciar4n
ciar4n - comment - 8 Oct 2016

Thank you @andrepereiradasilva although I just put some finishing touches on the work started by @dgt41

For some it may take a little getting use to but I think in time even they will appreciate the cleaner UI.

Well spotted. I have re-aligned the permissions dropdown in the latest commit.

permissions

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

Thank you @andrepereiradasilva although I just put some finishing touches on the work started by @dgt41

ok so nice work @dgt41 too!

did you manage to check this?

also notice some gray model Close/Cancel buttons mouseover border is blue. not surre again if related to the isis flat repaint

avatar ciar4n
ciar4n - comment - 8 Oct 2016

@andrepereiradasilva Could you detail how to replicate this issue? Unable to find an example in Chrome or FF.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

image

and some have flat borders.
image

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

Also noticed that some buttons text on mouseover get dark blue, some don't change the text color (this is the expected i think).

avatar ciar4n
ciar4n - comment - 8 Oct 2016

This is part of the modals CSS which is loaded separately from the template. Probably best for a separate PR as there is a few changes that could be made. Just waiting to see the outcome of the improved media manager.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

ok then

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

I have tested this item successfully on bcfaf6f

as comments above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12349.

avatar ciar4n ciar4n - change - 8 Oct 2016
The description was changed
avatar ciar4n ciar4n - edited - 8 Oct 2016
avatar zero-24
zero-24 - comment - 8 Oct 2016

@andrepereiradasilva

Also noticed that some buttons text on mouseover get dark blue, some don't change the text color (this is the expected i think).

Where? All places i found look good to me also on mouseover ? But i need to clear the cache to make sure the new template css is loaded ?

avatar zero-24 zero-24 - test_item - 8 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 8 Oct 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12349.

avatar zero-24
zero-24 - comment - 8 Oct 2016

@andrepereiradasilva please double check if that works we can set this RTC ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12349.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Oct 2016

@zero-24 reggarding that @ciar4n responded

This is part of the modals CSS which is loaded separately from the template. Probably best for a separate PR as there is a few changes that could be made. Just waiting to see the outcome of the improved media manager.

So i ignore that and tested this with success

avatar zero-24 zero-24 - change - 8 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 8 Oct 2016

RTC. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12349.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2016
Labels Added: ?
avatar mbabker
mbabker - comment - 8 Oct 2016

don't know if this is a patchtester issue or the isis flat repaint

Just for reference the only custom CSS the patch tester uses is GitHub's octicons, and only for the GitHub logo. Otherwise everything is themed entirely by the templates (even the Hathor overrides have no custom style rules).

avatar zero-24
zero-24 - comment - 8 Oct 2016

Patch tester works great. @mbabker I had also the issue but it is gone if you clear the cached css file with this PR.

avatar rdeutz rdeutz - change - 13 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-13 20:41:05
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Oct 2016
avatar rdeutz rdeutz - merge - 13 Oct 2016
avatar zero-24 zero-24 - close - 13 Oct 2016
avatar zero-24 zero-24 - change - 14 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment