[#12341] - [staging] Move HHVM Test fixes to staging
- Closed
- 16 Oct 2016
- Medium
- Build: staging
- # 12341
- Diff
- zero-24:hhvmtests
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
These are exactly the changes I have made in my test branches pending release of hhvm 3.15.2 or 3.16 which will resolve these issues.
I have been hesitant to submit the change for our call to pg_set_error_verbosity() since I'm unsure of any possible downstream consequences (I assume possibly none, but you know what they say about assuming). I'm also hesitant since this issue is fixed in hhvm 3.15.2. At the same time I have suggested the same change as a possible work around.
Looks good on code review and travis review.
The change to our call of pg_set_error_verbosity() is no longer needed as hhvm 3.15.2 has been released. We do still need the change to the separator for the DSN used in the tests as that patch has not been merged (they requested some additional changes).
Thanks closing than.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-16 08:01:15 |
| Closed_By | ⇒ | zero-24 |
The HHVM patch to fix the DSN separators to allow semicolon or space has been merged, the HHVM 3.16.0 STS release will have this, and is on the list of potential cherry picks for HHVM 3.15.3 LTS.
HHVM 3.16.0 STS is expected around 10/24/2016 and will automatically be the version tested on Travis CI
Thanks @Hackwar !