I have tested this item ✅ successfully on 463bbb6

on code review. seems fine to me

Agree @brianteeman can you confirm on review?

Do we need this sentence, it seem redundant to me.

"Select from all the pages listed in the dropdown menu"

Also I don't think the last sentence is required either as its also
redundant. It's also technically wrong as there is no redirection. You
can't be redirected to where you were before.

"If none are selected the redirection will be to the same page.".

.

On 7 Oct 2016 9:45 a.m., "zero-24" notifications@github.com wrote:

Agree @brianteeman https://github.com/brianteeman can you confirm on

review?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/tracker/
joomla-cms/12337.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12337 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8asrhi9HOulqkoFaOU8QN4_s-l1eks5qxga8gaJpZM4KQynM
.

I agree concerning "Select from all the pages listed in the dropdown menu." we can indeed get rid of it.

But not sure concerning the second one as it IS a redirection, even if it is to the same page. It is an information to the user of what will happen when login or logout. Which is exactly the purpose of a description.

How about.
The default is to remain on the same page.

On 7 Oct 2016 12:15 p.m., "infograf768" notifications@github.com wrote:

I agree concerning "Select from all the pages listed in the dropdown
menu." we can indeed get rid of it.

But not sure concerning the second one as it IS a redirection, even if it
is to the same page. It is an information to the user of what will happen
when login or logout. Which is exactly the purpose of a description.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12337 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VApGsuQ56Em2T9jRlZhbYbQT5Euks5qxinjgaJpZM4KQynM
.

Done. Please test. @andrepereiradasilva @brianteeman

I have tested this item ✅ successfully on 4a22418

We need one more test to confirm this as there were changes
@andrepereiradasilva

@yvesh can you take a look into the drone problems?

I have tested this item ✅ successfully on 4a22418

on code review

@infograf768 can you update your branch from joomla staging?

@zero-24 The fixes of highlighter.js are not in his branch. That's probably the reason drone is failing here.

lets see if that fixes the problem. Thanks @yvesh

RTC as last change was to correct conflicts