Ignore travis failing. I accidently pushed to the Joomla repo instead of mine first. Now travis is convinced the branch is still the Joomla based one and therefore doesn't exist :( Trust me that metadata checks won't fail the unit tests and I've not broken the code style rules :)

What/where is the reference doc explaining why these changes have been made and why you chose these settings. Without it it's not possible to check if you are correct to add these or if you have added correct tags with correct options.not saying they are wrong but they need provenance.

https://developers.google.com/search/docs/data-types/articles#article_types

Thanks for the link.

One thought is that this highlights that we should have a layout for the
full image not just the blog intro image.

HI Brian, give us a little while to go through this, there's some issues with it as it stands.

Ok I will delete my longer reply then :)

Some of this went sideways when we took the h1/h2 switch out in components/com_content/views/article/tmpl/default.php
Should be
If there is a page heading but no title <h1 itemprop=”name headline”>
If there is a page heading and a title <h1 itemprop=”name”>
If there is a title but no page heading <h2 itemprop=”name headline”>
If there is a title and a page heading <h2 itemprop=”headline”>
This makes the best use of things.
Same goes for category blog where you have the page header/category title.

Shove the longer reply in here Brian if you want. Other than fixing the props in the h1/h2 I don't think there's much more for this part of my series of PR's

https://developers.google.com/search/docs/data-types/articles#article_types

Aren't these the docs for AMP pages? They have lots of required elements that are definitely not required for html and definitely not correct for general web pages which are NOT fixed size like an AMP page. Pretty sure thats just not the link you meant to share.

Is it really correct to display an itemprop width value of the native image size.

Sorry but this seems really wrong to me - I dont see anything on schema.org about this

In general I've got no issue with improving SEO defaults but in the past
when it comes to markup like this it's been very limited and only stuff
defined in a standard like schema.org. Realizing Google's dominance, I
still think it's a little debatable whether core should be including stuff
specific to their features in our layouts (including AMP until we have full
core support for it, if that ever happens).

On Friday, October 7, 2016, Brian Teeman notifications@github.com wrote:

Is it really correct to display an itemprop width value of the native
image size.

Sorry but this seems really wrong to me - I dont see anything on
schema.org about this

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoU9AKe7kA2zynDjbJorqzPQo4QEuks5qxkuhgaJpZM4KQjpc
.

Sorry but the more I look at this the more I think you've misunderstood the
specs

On 7 October 2016 at 14:48, Michael Babker notifications@github.com wrote:

In general I've got no issue with improving SEO defaults but in the past
when it comes to markup like this it's been very limited and only stuff
defined in a standard like schema.org. Realizing Google's dominance, I
still think it's a little debatable whether core should be including stuff
specific to their features in our layouts (including AMP until we have full
core support for it, if that ever happens).

On Friday, October 7, 2016, Brian Teeman notifications@github.com wrote:

Is it really correct to display an itemprop width value of the native
image size.

Sorry but this seems really wrong to me - I dont see anything on
schema.org about this

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
,
or mute the thread
AAWfoU9AKe7kA2zynDjbJorqzPQo4QEuks5qxkuhgaJpZM4KQjpc>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YPgwyO5ze0ynD6CL1ON1SOb2md_ks5qxk2xgaJpZM4KQjpc
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

That documentation is a bit of a hybrid and is misleading.
This PR does not relate to AMP though, simply to a green light with Rich Snippets.
Schema is also used by other engines in their indexing:-
For structured data to pass the following are required

@type Article
name
headline
datePublished
author

publisher - not included in the PR due to need for a logo
image
articleBody

Optional without warning

inLanguage

Optional with warning

mainEntityOfPage
dateCreated
dateModified

Schema - imageObject - https://schema.org/ImageObject. Height and Width are both there.

So can you please provide a link that defines these schema

On 7 October 2016 at 15:15, Rowan Hoskyns Abrahall <notifications@github.com

wrote:

That documentation is a bit of a hybrid and is misleading.
This PR does not relate to AMP though, simply to a green light with Rich
Snippets.
Schema is also used by other engines in their indexing:-
For structured data to pass the following are required

@type https://github.com/type Article
name
headline
datePublished
author

publisher - not included in the PR due to need for a logo
image
articleBody

Optional without warning

inLanguage

Optional with warning

mainEntityOfPage
dateCreated
dateModified

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8aJABDN4btqNPv99QC-Sp5FD8IPlks5qxlP-gaJpZM4KQjpc
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

But not in the schema for Image https://schema.org/image ;)

My problem with all of this is that so far I've not seen anything here that
says the selected tags are anything other than arbitrarily selected. And
other than for AMP nothing that ays they are "required".

I'm all for adding schema but if we do it then we should do it everywhere
and be correct - we've already got enough incorrect schema tags in the
layouts

On 7 October 2016 at 15:32, Rowan Hoskyns Abrahall <notifications@github.com

wrote:

Schema - imageObject - https://schema.org/ImageObject. Height and Width
are both there.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8V6oED7nT_2EM2leEkCzNl8_JfJqks5qxlf_gaJpZM4KQjpc
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@wilsonge is this PR ready for testing or under debate?

I am closing this at this time. There has been no response to the requests for further information justifying this change. It can always be reopened if updated