? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
5 Oct 2016

Pull Request for Issue #11832

Summary of Changes

This is a rebased version of #11832 which looks broken against 3.7.x

Testing Instructions

Same as #11832 -> Apply the patch and browse administration.

Documentation Changes Required

None (screenshots maybe)

Credits

The original creator is @ciar4n and many other see #11832

avatar zero-24 zero-24 - open - 5 Oct 2016
avatar gunjanpatel gunjanpatel - change - 6 Oct 2016
Category Templates (admin)
avatar zero-24 zero-24 - change - 6 Oct 2016
Labels Added: ? ? ?
avatar zero-24 zero-24 - change - 6 Oct 2016
Labels Removed: ? ? ?
avatar ciar4n ciar4n - test_item - 6 Oct 2016 - Tested successfully
avatar ciar4n
ciar4n - comment - 6 Oct 2016

I have tested this item successfully on c7879c8

Everything looks good... thank you @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12319.

avatar brianteeman
brianteeman - comment - 6 Oct 2016

Why is this a release blocker?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12319.

avatar zero-24 zero-24 - change - 6 Oct 2016
Labels Removed: ?
avatar zero-24
zero-24 - comment - 6 Oct 2016

Oops i have add the label by mistake :) it is removend now

avatar C-Lodder C-Lodder - test_item - 7 Oct 2016 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 7 Oct 2016

I have tested this item successfully on c7879c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12319.

avatar zero-24 zero-24 - change - 7 Oct 2016
Status New Ready to Commit
avatar zero-24
zero-24 - comment - 7 Oct 2016

Thanks! -> RTC

cc: @rdeutz


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12319.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 7 Oct 2016
avatar rdeutz rdeutz - merge - 7 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - close - 7 Oct 2016
avatar rdeutz rdeutz - change - 7 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-07 12:15:54
Closed_By rdeutz
avatar zero-24
zero-24 - comment - 7 Oct 2016

❤️

avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Oct 2016

just updated my 3.7.x branch and isis looks nice!

BTW, just a detail, is it possible to also remove the text shadows in the text of labels and also in the message system (Error, Warning, Notice, Message)
image
image

avatar zero-24
zero-24 - comment - 7 Oct 2016

@andrepereiradasilva can you open a new issue for that.? I'm sure @ciar4n or an other CSS person can do this 😄

avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Oct 2016

done #12343

avatar zero-24
zero-24 - comment - 7 Oct 2016

👍

avatar ciar4n
ciar4n - comment - 7 Oct 2016

@zero-24 It looks like the original merge conflict was amended in just the template.css. Unfortunately recompiling the template.less reintroduces the conflict back in to the template.css?

avatar ciar4n
ciar4n - comment - 7 Oct 2016

Maybe not a conflict... just means there is a slight difference currently between the template.less and template.css

 .sidebar-nav .nav-list > li > a {
   color: #555;
   padding: 3px 25px;
-  margin-left: -25px;
-  margin-right: -25px;
+  margin-left: -26px;
+  margin-right: -26px;
 }
avatar ciar4n
ciar4n - comment - 7 Oct 2016

I was going to create a PR to fix #12343 .. I can just fix it in that?

avatar C-Lodder
C-Lodder - comment - 7 Oct 2016

It needs to be -26px for both left and right.

https://github.com/joomla/joomla-cms/pull/11973/files

avatar zero-24
zero-24 - comment - 7 Oct 2016

Thanks for spotting. Fixed with: #12346

Add a Comment

Login with GitHub to post a comment