User tests: Successful: Unsuccessful:
PHP 7.1 RC3
Joomla 3..6.x
No notice message on joomla update page
Notice: A non well formed numeric value encountered in C:\wamp\www\develop\administrator\components\com_installer\models\warnings.php on line 45
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Administration Components |
memory_limit 256M
i see also Low PHP memory limit. warning on the warning page.
But on the information page i see the correct values
Ok after remove th efix, the messages are gone, so the fix need to be fixed elsewhere
Ok, it should now work
Rel_Number | 0 | ⇒ | 12310 |
Relation Type | ⇒ | Pull Request for |
I have this issue on a brand new iMac with PHP 7.1RC installed from brew
System info
https://gist.github.com/PhilETaylor/3be36d59cd676fe36eda4f5520cae7a8
I have tested this item
After applying path the warnings are removed.
After applying path the warnings are removed.
Just to be sure. I gues path
is just a typo and should be patch
?
yeah - should be after applying the patch, the warnings were removed :)
Still an issue in PHP 7.1.0RC5
if someone else can test and approve, then we have a rtc
any testers?
Can we merge this one, now 7.1 is released.
I tested it :) and again today, still works ;-)
I dunno who else uses PHP 7.1 in production, it seems we are a rare breed of people ;-)
I have tested this item
Ran into the same issue. This fixes it. Thanks!
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Labels |
Removed:
?
?
|
Milestone |
Added: |
Category | Administration Components | ⇒ | Administration com_installer Components |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 21:51:22 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
?
|
I just reviewed the function, because i ran into the same issue with php 7.1 installed on an arch.
My comment:
The public function return_bytes($val) not only fixes the above issue, but the function was extended with new functionality and more costs.
It is a copy of http://php.net/manual/en/function.ini-get.php#106518 ! I'm not sure, whether this user example on php.net is the best for Joomla core.
a) Who needs the "gb" "kb" "mb" ? - Never tested.
b) What's about sending " "? - First, it jumps over the line if(empty($val))return 0;
.
c) Expensive regular expression, aso.
But who cares? - the function is fixed.
Wouldn't it be nice to support also 1.4M or 3.72k ?
Just set up a system with PHP 7.1 for a blog post, glad to see that there is a fix for this issue.
seen when accessing administrator/index.php?option=com_joomlaupdate
Notice: A non well formed numeric value encountered in \administrator\components\com_installer\models\warnings.php on line 45
Notice: A non well formed numeric value encountered in \administrator\components\com_installer\models\warnings.php on line 45
Notice: A non well formed numeric value encountered in \administrator\components\com_installer\models\warnings.php on line 45
Information about the system
Setting | Value |
---|---|
PHP Built On | (Windows 7 Professional Edition Service Pack 1) AMD64 |
Database Version | 5.7.17 |
Database Collation | utf8_general_ci |
Database Connection Collation | utf8mb4_general_ci |
PHP Version | 7.1.2 |
Web Server | Apache/2.4.20 (Win64) OpenSSL/1.0.2g PHP/7.1.2 |
WebServer to PHP Interface | apache2handler |
Joomla! Version | Joomla! 3.6.5 Stable [ Noether ] 1-December-2016 22:46 GMT |
Joomla! Platform Version | Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT |
User Agent | Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 |
another way to fix this that is a little more compact is to add this line between $last
and the switch case
$val = preg_replace('~\D~', '', $val);
as follows
public function return_bytes($val)
{
$val = trim($val);
$last = strtolower($val{strlen($val) - 1});
$val = preg_replace('~\D~', '', $val);
switch ($last)
{
// The 'G' modifier is available since PHP 5.1.0
case 'g':
$val *= 1024;
case 'm':
$val *= 1024;
case 'k':
$val *= 1024;
}
return (int) $val;
}
This is already fixed for the next release
Yes, glad to see that there is a fix for this issue.
Hi, I want to know that, exactly which version fixed this issue. Thanks
Please post your memory limit value.