? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
3 Oct 2016

Summary of Changes

JViewLegacy::assignRef has been deprecated for a long long time. This is the last usage of it in the CMS. This paves the way for it's removal in J4 with #12263

Testing Instructions

Ensure the newsfeed view continues to work as before

Documentation Changes Required

n/a

avatar wilsonge wilsonge - open - 3 Oct 2016
avatar wilsonge wilsonge - change - 3 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Category Front End Components
avatar andrepereiradasilva andrepereiradasilva - test_item - 3 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Oct 2016

I have tested this item successfully on 41b083f

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12296.

avatar zero-24
zero-24 - comment - 4 Oct 2016

@wilsonge please have a look into: wilsonge#29

avatar zero-24 zero-24 - test_item - 4 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Oct 2016

I have tested this item successfully on 41b083f

on review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12296.

avatar zero-24 zero-24 - change - 4 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 4 Oct 2016

RTC. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12296.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 4 Oct 2016

Thankyou for your PR :) I still think it's needed - just not here :)

avatar brianteeman
brianteeman - comment - 17 Oct 2016

Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release

avatar zero-24 zero-24 - change - 17 Oct 2016
Labels Added: ?
Removed: ?
avatar brianteeman brianteeman - close - 18 Oct 2016
avatar rdeutz rdeutz - change - 18 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-18 17:40:00
Closed_By rdeutz
avatar rdeutz rdeutz - close - 18 Oct 2016
avatar rdeutz rdeutz - merge - 18 Oct 2016
avatar brianteeman brianteeman - change - 18 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment