Success

User tests: Successful: Unsuccessful:

avatar drmmr763
drmmr763
3 Jun 2013

this should fix the tab issue and I ran the generatecss.php php

avatar drmmr763 drmmr763 - open - 3 Jun 2013
avatar nonumber
nonumber - comment - 5 Jun 2013

Please also fix in less files.

avatar drmmr763
drmmr763 - comment - 5 Jun 2013

Thanks for letting me know about this. Maybe you can show me where it is you can see that this is incorrect? I made the changes using PHPStorm. What tool are you using to see that the less file is using spaces vs tabs? Just trying to figure out how you see it so I can avoid making PRs that need to be updated.

avatar nonumber
nonumber - comment - 5 Jun 2013

With my comment I mean you should add the changes to the less file too. Not only to the css file.
The css files get generated based on the less files. So if you don't fix it in the less files, your fix will be overridden when Joomla is packaged.

avatar drmmr763
drmmr763 - comment - 5 Jun 2013

The changes should be in the less file actually. They just don't line up exactly because there were some other changes in the less file that never got built, so when I ran the generatecss.php file they did get included. But as far as I know both the less and the css should now be up to date. I had talked to Jean Marie about that.

avatar nonumber
nonumber - comment - 5 Jun 2013

Ok, cool :)

avatar infograf768 infograf768 - close - 8 Jun 2013
avatar phproberto
phproberto - comment - 10 Jun 2013

This is wrong:
https://github.com/joomla/joomla-cms/blob/master/media/jui/less/reset.less#L17

The changes introduced in the template.css are not in the less files so once recompiled are going to be removed.

avatar drmmr763
drmmr763 - comment - 12 Jun 2013

Are you sure? What happened was I added my lines to the .less and ran the compiler, and a few things that weren't currently in the .css were brought in along with my extra lines, so that's where the mismatch came from. I spoke to @infograf768 about it and he said it was alright. Just want to make sure this is all set.

avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment