? ? Failure

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
3 Oct 2016

Pull Request for Issue # .

Summary of Changes

  • Move files around to use autoload
  • Drop JSubMenuHelper as it was deprecated
  • Remove the relative sub menu module
  • remove useless entries from administrator/index.php

Testing Instructions

Admin should still work

Documentation Changes Required

avatar dgt41 dgt41 - open - 3 Oct 2016
avatar dgt41 dgt41 - change - 3 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Category Administration Components Modules SQL Installation Postgresql Libraries Unit Tests
avatar zero-24
zero-24 - comment - 3 Oct 2016

Please add the SQL Update files to remove the module

avatar dgt41
dgt41 - comment - 3 Oct 2016

@zero-24 you mean com_admin/sql ?

avatar zero-24
zero-24 - comment - 3 Oct 2016

Yes :)

avatar zero-24
zero-24 - comment - 3 Oct 2016

As well as the normal install sql under installation/sql

128b300 3 Oct 2016 avatar dgrammatiko hmmm
avatar dgt41
dgt41 - comment - 3 Oct 2016

@zero-24 ok, done. Travis happy (at least not complaining about these changes)

avatar zero-24
zero-24 - comment - 3 Oct 2016

@dgt41 i mean the extension ;) As you removed the mod_submenu extension we need to run on update a delete on the extension table and in the install sql we need to remove that extension too :)

avatar zero-24
zero-24 - comment - 3 Oct 2016

?

avatar zero-24 zero-24 - change - 3 Oct 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 3 Oct 2016

Documentation Changes Required

Removed extension & removed methods

avatar wilsonge wilsonge - change - 3 Oct 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-03 11:00:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Oct 2016
avatar wilsonge wilsonge - merge - 3 Oct 2016
avatar zero-24
zero-24 - comment - 3 Oct 2016

Add a Comment

Login with GitHub to post a comment