[#12272] - Joomla 4.0: Removing calls to JError::raiseError()
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: 4.0-dev
- # 12272
- Diff
- Hackwar:j4error
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR removes almost all calls to JError::raiseError() and replaces them with either a JViewGenericdataexception or a JUserAuthorizationException.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
There are also a couple new Exception classes added for either 3.6.3 or 3.7
from Andre. I think his was only a controller exception but I say it
because I think it dealt with authorization.
On Thursday, October 6, 2016, Hannes Papenberg notifications@github.com
wrote:
I reverted several of the changes to concentrate on the view..php files.
I also introduced 2 new exceptions, JViewGenericdataexception and
JUserAuthorizationException. Those 2 are consistently used throughout the
view..php files. I'm wondering if it wouldn't be better to create a new
branch and new PR with just those view.*.php files...—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12272 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfodYFEqP2cgK9trq2_5jZ7Bpp8aTiks5qxXctgaJpZM4KMJdF
.
I've reverted most of the stuff and started over and just concentrated on the view files. Taking babysteps here... I would keep it at this and do further refactoring in other PRs.
This is beginning to look significantly better :)
Should we merge this for the moment or do you want more changes before accepting this?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 20:50:32 |
| Closed_By | ⇒ | wilsonge |
I reverted several of the changes to concentrate on the view.html.php files. I also introduced 2 new exceptions, JViewGenericdataexception and JUserAuthorizationException. Those 2 are consistently used throughout the view.html.php files. I'm wondering if it wouldn't be better to create a new branch and new PR with just those view.html.php files...