Does this need to be a part of core? What are we gaining having an API endpoint where sites can send a "this works" or "this does not work" (basically a boolean flag) and a duplicate of the stats server data object without additional details about what the user's doing?

I honestly don't see much value in this as is. It's too generic and doesn't give any way for a user to explain what they are testing to validate a successful change or a way to report issues if they feel they've reached a fail state.

It might be generic at this state but it gives us information we don't have now. And we can make it more specific and add checklists for extensions to guide people to a process of testing. It is also a bit more then a boolean flag, you can say for each extension if you have tested it or not.

I have tested this item ✅ successfully on 413ba22

Tested on joomla 3.7

Overall it's a nice addition. It works allright.
But, as I tested on PHP7, I got these notices:
Notice : Undefined variable: disabled in layouts/joomla/form/field/radio.php on line 58

Notice : Undefined variable: required in layouts/joomla/form/field/radio.php on line 59

Notice : Undefined variable: autofocus in layouts/joomla/form/field/radio.php on line 60

Notice : Undefined variable: disabled in layouts/joomla/form/field/radio.php on line 68

Notice : Undefined variable: required in layouts/joomla/form/field/radio.php on line 78

Thanks for testing, the notice came from not proper testing if a var is set before using it. I am going to fix it later.

Good idea @rdeutz ! ?
Why don't we ship it as official extension? And promote it when we release RCs and Beta versions, instead of having it in the core?

I have my doubts that people will go find the extensions install it and then submit the results, if we don't ship it with core this all is a waste of time. Furthermore we only need to ship it while we are in alpha/beta/rc it don't has to be in a stable release. And even it is in a stable release, it can be disabled.

Wouldnt this work the same as com_patchtester. People who want to contribute to testing will install the component and use it

Furthermore we only need to ship it while we are in alpha/beta/rc it don't has to be in a stable release

We could use the same logic for including com_patchtester in those releases - which seems a good idea to me

@brianteeman I guess both this and com_patch_tester could somehow live in this branch for beta/rc. The only thing will be that people will have to do a discover installation, so the whole thing would remain simple (from db perspective)

@dgt41 yes

@rdeutz The libraries are listed in the unenabled extensions

We've kept the repo structure in a state that it only includes production assets (to the point that the Composer development dependencies like PHPUnit aren't included which makes maintaining that aspect of things more complex) with minimal extras (those extras basically being consolidated to the build and tests directories). I'm not convinced we should be littering the repo full of development only tools like this or patch tester, especially if don't even come installed by default (which makes packaging stable releases even more complex because you'd have to start stripping lines of code out of certain files). If it's in this repo it should be part of all packages and set up properly.

What about only add link(-s) on backend (somewhere) and by one click user can install developer/tester component.

Something like: Quick install one of the Joomla tester extensions.

For example links can be visible only if error reporting is set to maximum or if joomla version contains some dev chars.

Just use (new JVersion)->isInDevelopmentState(), don't try to parse the version string or rely on error reporting.

I like the idea!
Just some suggestions:

i could have google it to put the shame away from me but:
What is Vanilla Test? -> maybe a tooltip for me ;)

Site updated from -> First one the language string is missing.

Layout is broken at the bottom (Chrome)

and following error on certain points:
Notice: Undefined property: stdClass::$tested in /Applications/MAMP/htdocs/joomla-cms/administrator/components/com_jtestreport/views/default/tmpl/send.php on line 110

Is the list a list of the changes in the system? Would be perfect then to link to the specific Area (but i guess it´s too much effort to include this links)

Later on on this page should be maybe an explanation what is happening with the data etc.

Vanilla test is like vanilla ice cream. Clean and pure with nothing added

Let´s add this into the tooltip :-)

Still not sure myself that this is something to add to the CMS myself

On 28 October 2016 at 19:21, coolcat-creations notifications@github.com
wrote:

Let´s add this into the tooltip :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12258 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8W1BU_hBABQERDet6IqQk2YS4A5_ks5q4j0RgaJpZM4KMDc5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Setting to needs review. A decision needs to be made if this is something we want to have merged into the core - even if only distributed in staging and not in final releases

I have tested this item ✅ successfully on 413ba22

Missing String: