[#12254] - Work on com_finder (both admin and site)
- Fixed in Code Base
- 19 Jul 2017
- Medium
- Build: 3.8-dev
- # 12254
- Diff
- frankmayer:com_finder
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
Best practices, some optimization and cleaning up.
Testing Instructions
This should need only code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components Front End |
@andrepereiradasilva As far as I can tell changed indentation on purpose was in one file only.
The other changes of indentation was the removal of nested ifs, resulting in the code of that group being moved to the left.
btw. nice parameter hint
| Category | Administration Components Front End | ⇒ | Administration com_finder Front End Components |
I think the drone failure is a hickup. Could someone with permissions restart the check?
@frankmayer is this PR to be tested by Code review?
@franz-wohlkoenig yes code review.
@Quy thanks for Info. @frankmayer can you please wrote Test Instructions "Code review" in first Comment for willing Tester?
@Quy, @franz-wohlkoenig : Done and Done. Thanks
Conflicts resolved. Please test
Code review only should do.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12254.
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12254.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-19 12:26:00 |
| Closed_By | ⇒ | mbabker |
@frankmayer when you change tabs identation is more hard for testers to make a code review.
I normally append
?w=1(ignore whitespaces changes) to the "Files changed" tab URL (Ex:https://github.com/joomla/joomla-cms/pull/12254/files?w=1) in those cases to be more easy to spot the differences, but i think not all people know this "trick".So my sugestion is don't chnange code identation in this PRs