? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Oct 2016

This is a new editor-xtd plugin to allow you to easily insert a link to a contact when using the wysiwyg editor. It works exactly the same way as the insert article editor-xtd plugin

Testing Instructions

Easy test - install Joomla using https://github.com/brianteeman/joomla-cms/archive/contact-editorxtd.zip

Slightly harder test - Apply the patch using the com_patchtester. discover to find the plugin and then install AND enable it

editor

[Note] this editor plugin is available for all wysiwyg editor areas except for com_banners where it will not work (and has been disabled) as the editor is only for admin display.

1618fe7 2 Oct 2016 avatar brianteeman docs
avatar brianteeman brianteeman - open - 2 Oct 2016
avatar brianteeman brianteeman - change - 2 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2016
Category SQL Administration Components Postgresql MS SQL Language & Strings Installation Front End Plugins
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 2 Oct 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 Oct 2016
The description was changed
avatar zero-24
zero-24 - comment - 2 Oct 2016

Also the changes in the com_admin Script PHP is missing. ;)

avatar brianteeman
brianteeman - comment - 2 Oct 2016

admin script changes done

avatar zero-24
zero-24 - comment - 2 Oct 2016

Thanks. I can have a look into the source and prepare fixes there that can be aplyed here too. 👍

avatar brianteeman
brianteeman - comment - 2 Oct 2016

Yeah - Not a fan of changing the code just here.

avatar zero-24
zero-24 - comment - 2 Oct 2016

please see: #12260 do you want to do it yourself or do you want me to direct correct it?

avatar brianteeman
brianteeman - comment - 2 Oct 2016

In five minutes I stop work till Wednesday so if you could do it then it
can move forward while I am offline

avatar zero-24
zero-24 - comment - 2 Oct 2016

done

avatar zero-24 zero-24 - test_item - 2 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 2 Oct 2016

I have tested this item successfully on 0622cb7

👍


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12252.

avatar infograf768
infograf768 - comment - 3 Oct 2016

When I made the new editors-xtd menu plugin, I was told to use the prefix PLG_EDITORS-XTD_MENU_ instead of PLG_MENU_ to get:
$button->text = JText::_('PLG_EDITORS-XTD_MENU_BUTTON_MENU');

I suggest you do the same for this one.
Instead of PLG_CONTACT_BUTTON_CONTACT="Contact"
use
PLG__EDITORS-XTD_CONTACT_BUTTON_CONTACT="Contact"

avatar brianteeman
brianteeman - comment - 3 Oct 2016

It is EXACTLY the same as the article plugin

avatar infograf768
infograf768 - comment - 3 Oct 2016

that is what i also said at the time. the reply i got was that we should not reiterate the same error.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12252.

avatar infograf768
infograf768 - comment - 3 Oct 2016

see #11721 (comment)
in fact it was your comment...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12252.

avatar zero-24
zero-24 - comment - 3 Oct 2016
avatar zero-24
zero-24 - comment - 3 Oct 2016

Can you test that one @infograf768 ?

avatar zero-24
zero-24 - comment - 3 Oct 2016

With the last 3 commit i have just fixed the update sql's

avatar infograf768 infograf768 - test_item - 4 Oct 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 4 Oct 2016

I have tested this item successfully on 8191430

Looks OK here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12252.

avatar ghazal ghazal - test_item - 4 Oct 2016 - Tested successfully
avatar ghazal
ghazal - comment - 4 Oct 2016

I have tested this item successfully on 8191430


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12252.

avatar zero-24 zero-24 - change - 4 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 4 Oct 2016

RTC. Thanks!

@rdeutz new stuff for 3.7 :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12252.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 4 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-04 12:39:20
Closed_By rdeutz
avatar rdeutz rdeutz - close - 4 Oct 2016
avatar rdeutz rdeutz - merge - 4 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - close - 4 Oct 2016
avatar brianteeman
brianteeman - comment - 4 Oct 2016

Thanks

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment