In the installation of Joomla it is used like this:

JFactory::getDocument()->addScriptDeclaration(
<<<JS
    jQuery(document).ready(function($) {
        $(':input[name="jform[activateMultilanguage]"]').each(function(el){
            $(this).click(function(){Install.toggle('installLocalisedContent', 'activateMultilanguage', 1);});
            $(this).click(function(){Install.toggle('activatePluginLanguageCode', 'activateMultilanguage', 1);});
        });
        Install.toggle('installLocalisedContent', 'activateMultilanguage', 1);
        Install.toggle('activatePluginLanguageCode', 'activateMultilanguage', 1);
    });
JS
);

Gets rid of the variable as well, what do you think of that?

Leaves the HERE, currently in use: JS, CSS and ENDDATA. You introduce TAG.
Maybe standardize on HERE, considering the concept is known as HERE document. Thoughts?

@sovainfo Thanks for your constructive comments. Yes you are right on both counts. However, I didn't put much thought to those issues, as I didn't know if this would be accepted at all.

So, I just pushed a new commit dealing with these, since things look positive up to now.
I used JS for Javascript and introduced HTML for HTML. I also removed a senseless return... (I think this is included in one of the other PR's as well).

Like it that it tells you the language you are importing (JS, CSS & HTML), only hope it is not going to be used for a combination.

As you discovered, the last line requires a return.

IMHO if the combination is primarily HTML with a bit of javascript in it, then it should be HTML, if it's the other way around, then JS should be the tag.

Yes I discovered that ?

Conflicts resolved...

I have tested this item ✅ successfully on b04a96c

- inserted code into libraries/src/Form/Field/ModulepositionField.php (location has been moved)

• everything seems to work fine
• contributor is being asked to renew pull request due to patch application failure

@icampus

@frankmayer please renew pull request due to patch application failure

I have tested this item ? unsuccessfully on b04a96c


Your changes make definitely sense, but neither the function getInput() of ModulePositionField.php was in use, nor the code snippet you changed in behavior.php still exists.

I put a die() command into the getInput() function and load the page at path
/joomla-cms/administrator/index.php?option=com_modules&view=module&layout=edit but it didn't change anything. After applying that die() command completely outside of the class description, the page stops loading. So this detects that the path should be correct.

@icampus

Found the snippets in following path: libraries/src/Form/Field/ModulePosition.php and libraries/cms/html/behavior.php on version 3.10-dev

@nurcihandem and @priiish This was essentially a proposal to do these things differently. I did this almost two years ago :). Lots has changed since then. Not really sure how to handle this, now. Any ideas?

Hm, I would recommend to close this PR. We actually can't declare this as successful because it's not possible to test the functions. But if these functions should ever get in use again, no problem, the functions would work fine anyway like they did before.

OK, closing this, as there seems to be no interest in pursuing a change of those things. If anyone feels this should be reopened, just give me a shout. ?