[#12237] - [3.7] Add a Postinstall Message to warn users on nearly unsupported envoirments
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12237
- Diff
- zero-24:postinstall_joomla4
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for 3.7.x
Summary of Changes
Based on the Joomla 4 Manifesto by @wilsonge https://developer.joomla.org/news/658-joomla4-manifesto.html i have created a postinstall warning to all not supported versions.
Testing Instructions
- apply this patch Fire this SQL statment (replace #__ by your prefix)
INSERT INTO `#__postinstall_messages` (`extension_id`, `title_key`, `description_key`, `action_key`, `language_extension`, `language_client_id`, `type`, `action_file`, `action`, `condition_file`, `condition_method`, `version_introduced`, `enabled`)
VALUES
(700, 'COM_CPANEL_MSG_JOOMLA40_PRE_CHECKS_TITLE', 'COM_CPANEL_MSG_JOOMLA40_PRE_CHECKS_BODY', '', 'com_cpanel', 1, 'message', '', '', 'admin://components/com_admin/postinstall/joomla40checks.php', 'admin_postinstall_joomla40checks_condition', '3.7.0', 1);If you have a unspported version or use mssql you get a postinstall like this:
If you want you can test this but you have no unsupported version you can change e.g. the PHP Version check to version_compare(PHP_VERSION, '8.5.9', 'lt');
Documentation Changes Required
None
| Milestone |
Added: |
||
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Components SQL Postgresql MS SQL Language & Strings Installation |
They are save based on the last data / decisions we currently have. Btw. There is no message "you are save" there is just a message to unsupported versions that they are not save.
Maybe we can fix the wording to make this clear?
Without a definitive decision there really isnt anything that can be done
can you also mixin:
function is_32bit(){
return PHP_INT_SIZE === 4;
}and if true (32bit version of PHP) warn about strtotime max value is year 2038
Known unix bug: https://en.wikipedia.org/wiki/Year_2038_problem
1) Not appropriate for this PR
2) Do we really need a message for the 2038 problem?
@mbabker could be done in the requirements page as an asterisk or side note. Joomla most likely will be served from a linux machine, so informing people about bugs that might occur due to this fact is not a bad idea, I think.
So the answer is short answer is: probably not, a simple note in requirements should be sufficient.
The point is lets tell the i still run PHP 5.3 etc that Joomla 4 will be not supported on this platform.
Without a definitive decision there really isnt anything that can be done
I agree with your points but who can / would take such a final decision and when? At the release date of Joomla 4 or a week before? I personaly think we should tell the users our planings.
I just do that what i personaly would expect as user ;) -> Let me know if you know something about the planned feature.
But maybe i'm wrong and just try to overcomunitcate that, i'm not a marketing person ;).
It should be made clear in the message that these minimums are not finalized and may change before reaching the 4.0 beta (they shouldn't change after that and if they do there's probably been a major screwup in our choices). With that I'd say the message is just fine as is.
The 2038 bug is irrelevant for this PR.
Ok if it's made clear that these requirements may change before 4.0 beta then let's go with it :)
Maybe we can extend the Text with something like this: This are the currently planed minimum requirements that can be raised until the first Beta of 4.0 to be sure we would suggest you to use (PHP(7.0),mysql,postgresql version suggestions here).
or without the suggestions: "This are the currently planed minimum requirements that can maybe raised until the first Beta of 4.0 if we have more information this check will be updated."
That will pretty much guarantee that the message is ignored.
Ok so we stay with the current message and we can get tests here
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12237.
Can´t we just add something to the PHP nag Message?
https://issues.joomla.org/tracker/joomla-cms/11498
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12237.
Different purposes.
The PHP nag warns explicitly against running unsupported PHP versions from the PHP project or advises to upgrade when it is getting close to its end of support. That should continue to live on in the Joomla code base as long as Joomla's based on PHP.
This is a message specifically addressing the 4.0 minimum support requirements.
The php nag message is for unsupported by php the postinstall is for unsupported php and mysql etc configs by joomla.
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
Tested successfully at PBF NL
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12237.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12237.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 13:04:19 |
| Closed_By | ⇒ | rdeutz |
Hmm I'm unsure what to do about this. I think it's good. But these were provisional and not final requirements..... as per the manifesto. These versions are definitely going to be unsupported. But don't want people on higher req's to feel like they are 100% safe :/