See http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31066

Looks like this does not work here. See comments on tracker.

@infograf768 This doesn't have the UI changes which we'll also need to add before merging.

@infograf768 You're right. It only happened on articles which didn't already have any tags. Articles which already had tags were not affected. I fixed that in commit 662aac5. Please test again and thank you very much for the helpful bug report!

Hi,

should stay line 894:

$oldTags = json_decode($table->metadata)->tags;

as it is now when tags aren't stored in the metadata column anymore?

I'm not sure because I think this part of code is not reached during the normal use of tags.

Right that should go away.

For people testing please make sure to try the following combinations:

Article with no tags, save with tags.
Article with tags, save with another tag
Article with tags, save with no tags (should save and be deleted from ucm_table, ucm_base
Article with no tags, save with no tags

@nikosdion right now save is happening when there are no new or old tags and the rows are showing up in ucm_content and ucm_base and in the tags mapping table with a tag id of 0 ... so that means that the conditional that was checking for new and old is not working any more ... which makes sense since we were using metadata to test that. Now we should just us the old data and the valid data from jform. There should be code in the premetadata implementation that did this ...

.

Thanks Nicholas for this contribution!

I'll try to help on this sending a pull request to your branch with some of the issues that still exist in the tag system.

Awesome! Looking forward to it :)

#1267 can replace this if everyone is agreeable. This PR still had some use of metadata and also didn't handle all of the needed scenario.

It's fine by me.

This is resolved