?
avatar zero-24
zero-24
30 Sep 2016

Steps to reproduce the issue

https://travis-ci.org/joomla/joomla-cms/jobs/163936333

Expected result

No problems

Actual result

FILE: ...uild/joomla/joomla-cms/plugins/system/languagefilter/languagefilter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 170 | ERROR | Missing comment for param "$event" at position 1
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/languagefilter/languagefilter.php#L170

I'm not sure if travis / PHPCS just fouls us or something dirfferent is broken?

avatar zero-24 zero-24 - open - 30 Sep 2016
avatar zero-24 zero-24 - edited - 30 Sep 2016
avatar zero-24 zero-24 - change - 30 Sep 2016
Title
[4.0] Failing Travis
[4.0] Failing Travis on CS
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Sep 2016
Category Repository
avatar mbabker
mbabker - comment - 30 Sep 2016

Apparently we require an explanatory comment after the type and variable;
it's not optional there like it is on the return value.

On Friday, September 30, 2016, zero-24 notifications@github.com wrote:

Steps to reproduce the issue

https://travis-ci.org/joomla/joomla-cms/jobs/163936333
Expected result

No problems
Actual result

FILE: ...uild/joomla/joomla-cms/plugins/system/languagefilter/languagefilter.php

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

170 | ERROR | Missing comment for param "$event" at position 1

UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY

https://github.com/joomla/joomla-cms/blob/4.0-dev/
plugins/system/languagefilter/languagefilter.php#L170

I'm not sure if travis / PHPCS just fouls us or something dirfferent is
broken?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12217, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoQM2JR6N78frXD10Y7BABbQT4puOks5qvLxrgaJpZM4KKzzf
.

avatar zero-24
zero-24 - comment - 30 Sep 2016

Thanks done ?

avatar zero-24 zero-24 - change - 30 Sep 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-09-30 11:19:38
Closed_By zero-24
avatar zero-24 zero-24 - close - 30 Sep 2016

Add a Comment

Login with GitHub to post a comment